Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file separator used by Quarkus Maven Plugin build strategy when custom files are added to be platform independent #1362

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Oct 9, 2024

Summary

Hibernate Validator tests are failing as after we always use Quarkus Maven plugin build strategy for tests with forced dependencies, but file separator was hardcoded to the forward slash.

See failure: quarkus-qe/quarkus-test-suite#2074

I didn't test it on Windows, it would be more work than gain. This FW already runs tests on Windows with this strategy, because it was introduced exactly to fix race on Windows, so I hope there is reasonable expectation it will help.

2024-10-09T12:48:29.4819745Z java.lang.IllegalStateException: Merging algorithm doesn't work correctly. Java test file 'D:\a\quarkus-test-suite\quarkus-test-suite\http\hibernate-validator\src\test\java\io\quarkus\ts\http\hibernate\validator\sources' does not belong to the 'D:\a\quarkus-test-suite\quarkus-test-suite\http\hibernate-validator\src\test\java/' folder.
2024-10-09T12:48:29.4833600Z 	at io.quarkus.test.services.quarkus.QuarkusMavenPluginBuildHelper.addAppClassesToSrcMain(QuarkusMavenPluginBuildHelper.java:367)
2024-10-09T12:48:29.4836040Z 	at io.quarkus.test.services.quarkus.QuarkusMavenPluginBuildHelper.prepareMavenProject(QuarkusMavenPluginBuildHelper.java:143)
2024-10-09T12:48:29.4838635Z 	at io.quarkus.test.services.quarkus.QuarkusMavenPluginBuildHelper.buildArtifact(QuarkusMavenPluginBuildHelper.java:164)
2024-10-09T12:48:29.5018165Z 	at io.quarkus.test.services.quarkus.QuarkusMavenPluginBuildHelper.jvmModeBuild(QuarkusMavenPluginBuildHelper.java:152)
2024-10-09T12:48:29.5020782Z 	at io.quarkus.test.services.quarkus.ProdQuarkusApplicationManagedResourceBuilder.buildArtifact(ProdQuarkusApplicationManagedResourceBuilder.java:140)
2024-10-09T12:48:29.5022736Z 	at java.base/java.util.Optional.orElseGet(Optional.java:364)
2024-10-09T12:48:29.5025114Z 	at io.quarkus.test.services.quarkus.ProdQuarkusApplicationManagedResourceBuilder.tryToReuseOrBuildArtifact(ProdQuarkusApplicationManagedResourceBuilder.java:123)
2024-10-09T12:48:29.5027959Z 	at io.quarkus.test.services.quarkus.ProdQuarkusApplicationManagedResourceBuilder.build(ProdQuarkusApplicationManagedResourceBuilder.java:83)
2024-10-09T12:48:29.5030650Z 	at io.quarkus.test.services.quarkus.ProdQuarkusApplicationManagedResourceBuilder.build(ProdQuarkusApplicationManagedResourceBuilder.java:74)
2024-10-09T12:48:29.5032465Z 	at io.quarkus.test.bootstrap.BaseService.init(BaseService.java:323)
2024-10-09T12:48:29.5033846Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.initService(QuarkusScenarioBootstrap.java:235)
2024-10-09T12:48:29.5035651Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.initResourceFromField(QuarkusScenarioBootstrap.java:202)
2024-10-09T12:48:29.5074158Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.lambda$beforeAll$1(QuarkusScenarioBootstrap.java:64)
2024-10-09T12:48:29.5075637Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
2024-10-09T12:48:29.5076959Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.beforeAll(QuarkusScenarioBootstrap.java:64)
2024-10-09T12:48:29.5078621Z 	at io.quarkus.test.bootstrap.QuarkusScenarioBootstrap.beforeAll(QuarkusScenarioBootstrap.java:50)
2024-10-09T12:48:29.5079942Z 	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik michalvavrik added the triage/backport-1.5? Quarkus 3.15 stream label Oct 9, 2024
@michalvavrik michalvavrik merged commit c9ceb6f into quarkus-qe:main Oct 9, 2024
8 checks passed
@michalvavrik michalvavrik deleted the feature/fix-mvn-plugin-buid-strategy-on-win-separator branch October 9, 2024 18:39
@michalvavrik michalvavrik removed the triage/backport-1.5? Quarkus 3.15 stream label Oct 9, 2024
@michalvavrik michalvavrik mentioned this pull request Oct 9, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants