Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add propagation of maven.repo.local on windows machine #1373

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Oct 17, 2024

Summary

In case of linux we propagating all build arguments which also contains maven.repo.local.
This is not case on windows where we getting only specific set of them (starts with quarkus).
When #1359 was introducedThe build start separatly using maven. But when provided path to local maven repo was set as cmd argument and the artifact is not public, causing the windows failing the build of app with that forced artifact.

Tested it localy on win and it's working.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Release (follows conventions described in the RELEASE.md)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

In case of linux we propagating all build arguments which also contains `maven.repo.local`.
This is not case on windows where we getting only specific set of them (starts with Quarkus).
When quarkus-qe#1359 was introducedThe build start separatly using maven.
But when provided path to local maven repo was set as cmd argument and the artifact is not public,
causing the windows failing the build of app with that forced artifact.
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this patching is necessary as implementing perfect argument propagation strategy would take too much effort. Thanks for the fix.

@michalvavrik michalvavrik merged commit afdcab9 into quarkus-qe:main Oct 17, 2024
7 checks passed
@michalvavrik michalvavrik added the triage/backport-1.5? Quarkus 3.15 stream label Oct 17, 2024
This was referenced Oct 22, 2024
@jedla97 jedla97 removed the triage/backport-1.5? Quarkus 3.15 stream label Oct 23, 2024
@jedla97 jedla97 mentioned this pull request Oct 23, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants