Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Quarkus Quickstart tests #754

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Enable Quarkus Quickstart tests #754

merged 1 commit into from
Apr 22, 2023

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Apr 21, 2023 •
edited by michalvavrik
Loading

Summary

Enable Quarkus Quickstart tests.
Make quarkus app from development branch that uses Quarkus 3 so we can test it before Quarkus Quickstarts main starts using Quarkus 3.0.0.Final

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

michalvavrik
michalvavrik approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michalvavrik
Copy link
Member

run tests

michalvavrik
michalvavrik requested changes Apr 21, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, QS development branch works with snapshot and we don't have it in Github CI available :-) Didn't realize, let's replace original @Disabled with @EnabledOnQuarkusVersion(version = "999-SNAPSHOT", reason = "bla bla")

@gtroitsk
Enable Quarkus Quickstart tests only on 999-SNAPSHOT
d0ca10e 
Make quarkus app from development branch that uses Quarkus 3
@gtroitsk
Copy link
Member Author

run tests

@michalvavrik michalvavrik merged commit 4b73a1e into quarkus-qe:main Apr 22, 2023
@gtroitsk gtroitsk deleted the quickstarts-disabled-tests branch April 26, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtroitsk @michalvavrik