Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3.z] Pinning external application branches to 3.2 #905

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

mjurc
Copy link
Member

@mjurc mjurc commented Oct 13, 2023

Summary

  • Pinning usages of Camel on Quarkus and Quarkus quickstarts to 3.2 release stream branches.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

* Pinning usages of Camel on Quarkus and Quarkus quickstarts to 3.2
  release stream branches.
@mjurc mjurc requested a review from rsvoboda October 13, 2023 09:13
@mjurc mjurc self-assigned this Oct 13, 2023
@mjurc
Copy link
Member Author

mjurc commented Oct 13, 2023

run tests

Copy link
Member

@rsvoboda rsvoboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's wait for CI.

@rsvoboda
Copy link
Member

What about TodoDemoIT. That should probably have some pinning too @mjurc ?

@rsvoboda
Copy link
Member

aha, @Disabled("Disabled until Quarkus 3 is released and TODO application migrates to it")

@mjurc
Copy link
Member Author

mjurc commented Oct 13, 2023

Sadly last time that app got an update was with 2.7.1.

@rsvoboda
Copy link
Member

Run OpenShift Tests in JVM are red, @mjurc can you investigate?

@mjurc
Copy link
Member Author

mjurc commented Oct 13, 2023

@rsvoboda The job needs to be ran on JDK17 executors. I will update it, as JDK11 is deprecated anyway - wdyt?

@rsvoboda
Copy link
Member

What requires JDK 17?

@mjurc
Copy link
Member Author

mjurc commented Oct 13, 2023

@rsvoboda The Apache Camel extension for Quarkus quickstart has compilation target set to JDK17. Since we run the tests on JDK 11, the application gets built locally into container image, deployed and referenced from OpenShift deployment.

Sadly, since the executor is on JDK 11, it cannot compile the quickstart:
https://github.com/apache/camel-quarkus-examples/blob/3.2.x/file-bindy-ftp/pom.xml#L41

@mjurc mjurc merged commit e482038 into quarkus-qe:1.3.z Oct 14, 2023
9 checks passed
mjurc added a commit to mjurc/quarkus-test-framework that referenced this pull request Oct 14, 2023
* Removing TODOs that have been resolved by
  quarkus-qe#905.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants