Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform non-quarkus config properties to OpenShift environment variables using underscore for non-alphanumeric chars when runtime is Quarkus #917

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Oct 18, 2023

Summary

#904 follow-up, fixes OpenShiftAmqpAmqIT. Quarkus runtime is using MicroProfile under the hood for all configuration properties. It is important to also transform properties without Quarkus prefix like amq-host.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik force-pushed the feature/fix-ocp-non-quarkus-config-prop-env-conversion branch from fb62b28 to 8f33356 Compare October 18, 2023 12:23
@michalvavrik
Copy link
Member Author

run tests

1 similar comment
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik michalvavrik changed the title Transform non-quarkus config properties to OpenShift environment variables using underscore for non-alphanumeric chars Transform non-quarkus config properties to OpenShift environment variables using underscore for non-alphanumeric chars when runtime is Quarkus Oct 18, 2023
@michalvavrik michalvavrik force-pushed the feature/fix-ocp-non-quarkus-config-prop-env-conversion branch from 8f33356 to 510f5bd Compare October 18, 2023 13:08
@michalvavrik michalvavrik force-pushed the feature/fix-ocp-non-quarkus-config-prop-env-conversion branch from 510f5bd to e8be63a Compare October 18, 2023 13:20
@michalvavrik
Copy link
Member Author

run tests

@michalvavrik
Copy link
Member Author

I have verified that 2 remaining OCP failures are related to the Quarkus version (OpenShiftStrimziKafkaWithRegistryMessagingIT, OpenShiftStrimziOperatorKafkaWithoutRegistryMessagingIT) are reproducable on main as well (not related to this PR), they go down to the Quarkus bump (which fixed more issues). I'll fix them in a separate PR - already working on it.

@fedinskiy
Copy link
Contributor

@michalvavrik what's with Github JVM failure?

@michalvavrik
Copy link
Member Author

@michalvavrik what's with Github JVM failure?

@fedinskiy #921, it can't be fixed with a reasonable effort, so I disabled it

Copy link
Contributor

@fedinskiy fedinskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@fedinskiy fedinskiy merged commit c4d9f9a into quarkus-qe:main Oct 19, 2023
6 of 9 checks passed
@michalvavrik michalvavrik deleted the feature/fix-ocp-non-quarkus-config-prop-env-conversion branch October 19, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants