-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform non-quarkus config properties to OpenShift environment variables using underscore for non-alphanumeric chars when runtime is Quarkus #917
Conversation
run tests |
fb62b28
to
8f33356
Compare
run tests |
1 similar comment
run tests |
quarkus-test-openshift/src/main/java/io/quarkus/test/bootstrap/inject/OpenShiftClient.java
Outdated
Show resolved
Hide resolved
quarkus-test-openshift/src/main/java/io/quarkus/test/bootstrap/inject/OpenShiftClient.java
Outdated
Show resolved
Hide resolved
8f33356
to
510f5bd
Compare
quarkus-test-openshift/src/main/java/io/quarkus/test/bootstrap/inject/OpenShiftClient.java
Outdated
Show resolved
Hide resolved
quarkus-test-openshift/src/main/java/io/quarkus/test/bootstrap/inject/OpenShiftClient.java
Show resolved
Hide resolved
510f5bd
to
e8be63a
Compare
run tests |
I have verified that 2 remaining OCP failures are related to the Quarkus version ( |
@michalvavrik what's with Github JVM failure? |
@fedinskiy #921, it can't be fixed with a reasonable effort, so I disabled it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix!
Summary
#904 follow-up, fixes OpenShiftAmqpAmqIT. Quarkus runtime is using MicroProfile under the hood for all configuration properties. It is important to also transform properties without Quarkus prefix like
amq-host
.Please check the relevant options
run tests
phrase in comment)Checklist: