Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.4.0.Beta1 #953

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Release 1.4.0.Beta1 #953

merged 1 commit into from
Nov 16, 2023

Conversation

michalvavrik
Copy link
Member

@michalvavrik michalvavrik commented Nov 15, 2023 •
edited
Loading

Summary

I read release-related files and it shouldn't be an issue to have empty release. The 1.4.x is supposed to be used with Quarkus version greater than 3.2. This PR follows-up #952 so I suggest not to worry about OCP CI.

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Release
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member Author

@rsvoboda has other tasks, I'm adding @jsmrcka as a reviewer

@michalvavrik michalvavrik requested review from jsmrcka and removed request for rsvoboda November 16, 2023 10:09
jsmrcka
jsmrcka approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@jsmrcka jsmrcka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsmrcka jsmrcka merged commit 4375daf into main Nov 16, 2023
7 checks passed
@jsmrcka jsmrcka deleted the release/1.4.0.Beta1 branch November 16, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsmrcka jsmrcka jsmrcka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michalvavrik @jsmrcka