Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for cookie serialization #1514

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Add test coverage for cookie serialization #1514

merged 1 commit into from
Nov 10, 2023

Conversation

jedla97
Copy link
Member

@jedla97 jedla97 commented Nov 9, 2023

Summary

Hi, this PR adding coverage for quarkusio/quarkus#35582. Which fail jakarta cookies serialization when using native.

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@jedla97 jedla97 added the triage/backport-3.2 RHBQ Ghost LTS release label Nov 9, 2023
michalvavrik
michalvavrik approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please adjust naming and merge it

http/http-advanced-reactive/src/test/java/io/quarkus/ts/http/advanced/reactive/CookiesIT.java Outdated Show resolved Hide resolved
michalvavrik
michalvavrik approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@michalvavrik michalvavrik merged commit 43fc856 into quarkus-qe:main Nov 10, 2023
7 checks passed
@michalvavrik michalvavrik removed the triage/backport-3.2 RHBQ Ghost LTS release label Nov 21, 2023
@michalvavrik michalvavrik mentioned this pull request Nov 21, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jedla97 @michalvavrik