Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverage for JSON tokens #1813

Merged
merged 1 commit into from
May 30, 2024
Merged

Coverage for JSON tokens #1813

merged 1 commit into from
May 30, 2024

Conversation

fedinskiy
Copy link
Contributor

Summary

Adds missing coverage for token propagation

No changes in Reactive due to quarkusio/quarkus#40884
https://issues.redhat.com/browse/QUARKUS-4179

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy fedinskiy requested a review from mocenas May 30, 2024 06:45
@fedinskiy fedinskiy self-assigned this May 30, 2024
mocenas
mocenas approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@mocenas mocenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mocenas mocenas merged commit 563efd8 into quarkus-qe:main May 30, 2024
8 checks passed
@fedinskiy fedinskiy deleted the oidc-tp branch May 30, 2024 08:07
@jedla97
Copy link
Member

jedla97 commented Jun 4, 2024

@fedinskiy shouldn't this have backport label as the jira target 3.8.5?

@fedinskiy fedinskiy mentioned this pull request Jun 6, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocenas mocenas mocenas approved these changes

Assignees

@fedinskiy fedinskiy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedinskiy @jedla97 @mocenas