Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quarkus Amazon Services to 2.7.2 #1048

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

scrocquesel
Copy link
Contributor

Aligned with Quarkus 3.6.0

Make sure that you have run ./mvnw -Dsync and included the changes in your pull request (preferably in the same commit, unless it makes sense to do otherwise).

Thanks!

@scrocquesel
Copy link
Contributor Author

Please note that the AWS SDK, starting from version 2.21.20, changed the default protocol for SQS, potentially causing compatibility issues with testing tools in older versions such as LocalStack prior to 3.0.0.
As we share the version with Camel BOM, it may be recommended to review this by the Quarkus Camel maintainers as their bom is declaring older version of the sdk.

@quarkus-bot

This comment has been minimized.

@scrocquesel scrocquesel changed the title Update Quarkus Amazon Services to 2.7.0 Update Quarkus Amazon Services to 2.7.1 Nov 25, 2023
@quarkus-bot

This comment has been minimized.

@scrocquesel scrocquesel marked this pull request as draft November 25, 2023 18:06
@scrocquesel scrocquesel changed the title Update Quarkus Amazon Services to 2.7.1 Update Quarkus Amazon Services to 2.7.2 Nov 25, 2023
@scrocquesel scrocquesel marked this pull request as ready for review November 25, 2023 19:04
@quarkus-bot

This comment has been minimized.

@quarkus-bot

This comment has been minimized.

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 26, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Comment on lines +431 to +437
<localstack.container.image>localstack/localstack:3.0.1</localstack.container.image>
</systemProperties>
</test>
<test>
<artifact>org.apache.camel.quarkus:camel-quarkus-integration-test-aws2-quarkus-client-grouped:${camel-quarkus-test-list.version}</artifact>
<systemProperties>
<localstack.container.image>localstack/localstack:3.0.1</localstack.container.image>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ppalaga FYI, I overrode the localstack version to address the change in the SQS protocol with recent AWS SDK versions. This override can be removed once the localstack version is updated on the Quarkus Camel side.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This override can be removed once the localstack version is updated on the Quarkus Camel side

I took care of it here for 3.7.0 apache/camel-quarkus#5558.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look at the Camel side!

@gsmet gsmet merged commit 40da5f5 into quarkusio:main Nov 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants