-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Quarkus Amazon Services to 2.7.2 #1048
Conversation
Please note that the AWS SDK, starting from version 2.21.20, changed the default protocol for SQS, potentially causing compatibility issues with testing tools in older versions such as LocalStack prior to 3.0.0. |
This comment has been minimized.
This comment has been minimized.
75fcf35
to
7ac18c0
Compare
This comment has been minimized.
This comment has been minimized.
7ac18c0
to
8cbba10
Compare
This comment has been minimized.
This comment has been minimized.
8cbba10
to
8f9d5b5
Compare
8f9d5b5
to
de5cb85
Compare
This comment has been minimized.
This comment has been minimized.
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
<localstack.container.image>localstack/localstack:3.0.1</localstack.container.image> | ||
</systemProperties> | ||
</test> | ||
<test> | ||
<artifact>org.apache.camel.quarkus:camel-quarkus-integration-test-aws2-quarkus-client-grouped:${camel-quarkus-test-list.version}</artifact> | ||
<systemProperties> | ||
<localstack.container.image>localstack/localstack:3.0.1</localstack.container.image> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ppalaga FYI, I overrode the localstack version to address the change in the SQS protocol with recent AWS SDK versions. This override can be removed once the localstack version is updated on the Quarkus Camel side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This override can be removed once the localstack version is updated on the Quarkus Camel side
I took care of it here for 3.7.0 apache/camel-quarkus#5558.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having a look at the Camel side!
Aligned with Quarkus 3.6.0
Make sure that you have run
./mvnw -Dsync
and included the changes in your pull request (preferably in the same commit, unless it makes sense to do otherwise).Thanks!