Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANNER-1709 Avoid deprecated penalize/reward overloads #1167

Merged
merged 1 commit into from
Oct 18, 2022
Merged

PLANNER-1709 Avoid deprecated penalize/reward overloads #1167

merged 1 commit into from
Oct 18, 2022

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Sep 7, 2022

Check list:

Your pull request:

  • targets the development branch
  • uses the 999-SNAPSHOT version of Quarkus
  • has tests (mvn clean test)
  • works in native (mvn clean package -Pnative)
  • has integration/native tests (mvn clean verify -Pnative)
  • makes sure the associated guide must not be updated
  • links the guide update pull request (if needed)
  • updates or creates the README.md file (with build and run instructions)
  • for new quickstart, is located in the directory component-quickstart
  • for new quickstart, is added to the root pom.xml and README.md

triceo added a commit to triceo/quarkus that referenced this pull request Sep 7, 2022
@quarkus-bot

This comment has been minimized.

@triceo triceo marked this pull request as ready for review October 12, 2022 12:11
@triceo
Copy link
Contributor Author

triceo commented Oct 12, 2022

@gsmet Can you please assign someone for review?

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash the commits?

@quarkus-bot

This comment has been minimized.

@triceo
Copy link
Contributor Author

triceo commented Oct 18, 2022

@cescoffier It seems like the test failure is not related to my changes. Anything I could/should do about it?

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 18, 2022

Failing Jobs - Building 9b794e9

Status Name Step Failures Logs Raw logs
Build - JDK 11 Build with Maven Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Build - JDK 11 #

- Failing: opentelemetry-quickstart 

📦 opentelemetry-quickstart

org.acme.opentelemetry.TracedResourceTest.testChainEndpoint - More details - Source on GitHub

java.lang.RuntimeException: java.lang.IllegalArgumentException: Multiple matching properties for name "opentelemetry.tracer.exporter.otlp.enabled" property was matched by both public java.lang.Boolean io.quarkus.opentelemetry.runtime.exporter.otlp.OtlpExporterConfig$OtlpExporterBuildConfig.enabled and public java.lang.Boolean io.quarkus.opentelemetry.exporter.otlp.runtime.OtlpExporterConfig$OtlpExporterBuildConfig.enabled. This is likely because you have an incompatible combination of extensions that both define the same properties (e.g. including both reactive and blocking database extensions)
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:641)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:712)

@triceo
Copy link
Contributor Author

triceo commented Oct 18, 2022

@gsmet I see the opentelementry quickstart failing. I do not understand how my changes could be related to this failure, and I have not seen it fail locally.

@gsmet gsmet merged commit 42bb0a6 into quarkusio:development Oct 18, 2022
@triceo triceo deleted the PLANNER-1709 branch October 18, 2022 08:55
gsmet pushed a commit to quarkusio/quarkus that referenced this pull request Feb 1, 2023
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Feb 7, 2023
This PR is a DRAFT and will not undrafted before quarkusio/quarkus-quickstarts#1167.

(cherry picked from commit 38ee8be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants