Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a periodic workflow verifying the QS against the Quarkus master #420

Merged
merged 4 commits into from
Jan 17, 2020

Conversation

cescoffier
Copy link
Member

The implemented workflow runs every 6 hours and verifies the quickstarts against the latest Quarkus (master branch). It builds the native executables using the container policy and runs native ITs.

To ease debugging and to avoid waiting for the next tick, the dispatch event is also enabled. So we can trigger the workflow by issuing a curl command as follows:

curl -X POST -H "Authorization: token $GITHUB_TOKEN" \
          -H "Accept: application/vnd.github.everest-preview+json"  \
         -H "Content-Type: application/json" \
          https://api.github.com/repos/quarkusio/quarkus-quickstarts/dispatches \
         --data '{"event_type": "internal_event"}'

The build reporting uses Github Issues. It creates, closes or adds a comment to an issue named Quickstarts Native Build failed against Quarkus Master. If the issue does not exist it creates it at the first failure. It the issue exist and the build passes, the issue is closed (with a comment). If the build still fails, a comment is added. The comment contains the SHAs of the quickstart and quarkus commits.

At the moment the STM quickstart is ignored. An issue has been found yesterday and is currently being reviewed (quarkusio/quarkus#6553).

IMPORTANT: The build takes almost 3h to run...

@cescoffier
Copy link
Member Author

Forgot to mention that the workflow uses Java 8 as it does the native build.

@cescoffier
Copy link
Member Author

@emmanuelbernard ^

.github/NativeBuildReport.kts Outdated Show resolved Hide resolved
.github/NativeBuildReport.kts Outdated Show resolved Hide resolved
.github/NativeBuildReport.kts Outdated Show resolved Hide resolved
.github/NativeBuildReport.kts Outdated Show resolved Hide resolved
@cescoffier cescoffier force-pushed the features/ci-native-build branch from 9ffc5e4 to 4d248b5 Compare January 15, 2020 16:39
@geoand
Copy link
Collaborator

geoand commented Jan 16, 2020

Should we merge this and start getting some results?

We can always improve it if things don't go as planned

@cescoffier
Copy link
Member Author

There is one thing that worries me...
The issue lookup is taking a lot of time because the main quarkus repo has a lot of issues (opened and closed). I was wondering if I should not create the issue manually, and do a lookup by id which would be much faster.

WDYT?

@geoand
Copy link
Collaborator

geoand commented Jan 16, 2020

There is one thing that worries me...
The issue lookup is taking a lot of time because the main quarkus repo has a lot of issues (opened and closed). I was wondering if I should not create the issue manually, and do a lookup by id which would be much faster.

WDYT?

I agree, let's just do that instead of risk something timing out and us loosing the report completely

@cescoffier
Copy link
Member Author

Also, with quarkusio/quarkus#6555, we can remove the workaround for STM.

gsmet
gsmet previously requested changes Jan 16, 2020
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added two very small comments.

.github/NativeBuildReport.kts Outdated Show resolved Hide resolved
.github/workflows/native-build-development.yml Outdated Show resolved Hide resolved
@cescoffier
Copy link
Member Author

Alright, it's now going to report on quarkusio/quarkus#6588.

@cescoffier
Copy link
Member Author

The CI failed... this is exactly why we need this in because it would report this issue in quarkus.

@geoand
Copy link
Collaborator

geoand commented Jan 17, 2020

I will probably copy the general idea of this in order to setup a periodic CI run of the Quarkus Platform (when the pieces are in place which they aren't yet but should be soon).

@geoand
Copy link
Collaborator

geoand commented Jan 17, 2020

@cescoffier the quickstart issues should be fixed now, can you rebase the PR?

@cescoffier cescoffier force-pushed the features/ci-native-build branch from 2005af4 to 568123a Compare January 17, 2020 10:57
@cescoffier
Copy link
Member Author

@geoand done.

@geoand geoand dismissed gsmet’s stale review January 17, 2020 11:14

raised issues have been addressed

@geoand
Copy link
Collaborator

geoand commented Jan 17, 2020

@cescoffier We aren't waiting for anything else for this one right? Should we merge and have it start working?

@cescoffier
Copy link
Member Author

cescoffier commented Jan 17, 2020 via email

@geoand
Copy link
Collaborator

geoand commented Jan 17, 2020

Merging then, thanks!

@geoand geoand merged commit 5de8608 into quarkusio:development Jan 17, 2020
@cescoffier cescoffier deleted the features/ci-native-build branch January 17, 2020 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants