-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a periodic workflow verifying the QS against the Quarkus master #420
Implement a periodic workflow verifying the QS against the Quarkus master #420
Conversation
Forgot to mention that the workflow uses Java 8 as it does the native build. |
9ffc5e4
to
4d248b5
Compare
Should we merge this and start getting some results? We can always improve it if things don't go as planned |
There is one thing that worries me... WDYT? |
I agree, let's just do that instead of risk something timing out and us loosing the report completely |
Also, with quarkusio/quarkus#6555, we can remove the workaround for STM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added two very small comments.
Alright, it's now going to report on quarkusio/quarkus#6588. |
The CI failed... this is exactly why we need this in because it would report this issue in quarkus. |
I will probably copy the general idea of this in order to setup a periodic CI run of the Quarkus Platform (when the pieces are in place which they aren't yet but should be soon). |
@cescoffier the quickstart issues should be fixed now, can you rebase the PR? |
…test quarkus (master) including native build and IT
2005af4
to
568123a
Compare
@geoand done. |
@cescoffier We aren't waiting for anything else for this one right? Should we merge and have it start working? |
Nothing I’m aware of.
…On 17 Jan 2020 at 12:18 +0100, Georgios Andrianakis ***@***.***>, wrote:
@cescoffier We aren't waiting for anything else for this one right? Should we merge and have it start working?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Merging then, thanks! |
The implemented workflow runs every 6 hours and verifies the quickstarts against the latest Quarkus (master branch). It builds the native executables using the container policy and runs native ITs.
To ease debugging and to avoid waiting for the next tick, the dispatch event is also enabled. So we can trigger the workflow by issuing a curl command as follows:
The build reporting uses Github Issues. It creates, closes or adds a comment to an issue named
Quickstarts Native Build failed against Quarkus Master
. If the issue does not exist it creates it at the first failure. It the issue exist and the build passes, the issue is closed (with a comment). If the build still fails, a comment is added. The comment contains the SHAs of the quickstart and quarkus commits.At the moment the STM quickstart is ignored. An issue has been found yesterday and is currently being reviewed (quarkusio/quarkus#6553).
IMPORTANT: The build takes almost 3h to run...