Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic usage for AWT extension, watermarking images #961

Merged
merged 2 commits into from
Nov 7, 2021

Conversation

Karm
Copy link
Member

@Karm Karm commented Oct 18, 2021

This is a Quickstart showcasing an overhauled AWT extension.

Depends on quarkusio/quarkus#20850

@cescoffier
Copy link
Member

cescoffier commented Oct 25, 2021

Nice!

Your PR must target the "development" branch. In addition, add it to the README file and to the pom.xml from the root directory.

@@ -0,0 +1,54 @@
####
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would delete the docker files - there are irrelevant for the quickstart.

Copy link
Member Author

@Karm Karm Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cescoffier They are very much relevant as they show the user which additional libraries to install. It is explained in the README.md.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok! Missed that!
Do we need all? (typically distroless can be the fun one here).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cescoffier, I addressed the notes, namely:

  • the base is development now
  • pom.xml, README.md are fixed
  • comment about the source of fonts in Application.java is clarified
  • and last but not least, I added Distroless Dockerfile, with a huge Beware banner, describing how other Quickstarts use Debian and why that won't do...and how fragile such setup is anyway. It works now with UBI 8.4 based chain of images. It might need an update when we upgrade to 8.5, but perhaps not (those libs versions are pretty stabilized).

@Karm
Copy link
Member Author

Karm commented Oct 25, 2021

Nice!

Your PR must target the "development" branch. In addition, add it to the README file and to the pom.xml from the root directory.

Will do.

@cescoffier cescoffier merged commit d2bcc91 into quarkusio:development Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants