Skip to content

Commit

Permalink
Suspend GET requests as well
Browse files Browse the repository at this point in the history
If they are not suspended and there is a dispatch it can break
vert.x websockets.

Fixes #17327

(cherry picked from commit bc70b26)
  • Loading branch information
stuartwdouglas authored and gsmet committed May 21, 2021
1 parent bd167a5 commit 125d35a
Showing 1 changed file with 1 addition and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,7 @@ public void handle(HttpServerRequest httpServerRequest) {
//as it is possible filters such as the auth filter can do blocking tasks
//as the underlying handler has not had a chance to install a read handler yet
//and data that arrives while the blocking task is being processed will be lost
if (!httpServerRequest.rawMethod().equals(GET)) {
//we don't pause for GET requests, as there is no data
httpServerRequest.pause();
}
httpServerRequest.pause();
Handler<HttpServerRequest> rh = VertxHttpRecorder.rootHandler;
if (rh != null) {
rh.handle(httpServerRequest);
Expand Down

0 comments on commit 125d35a

Please sign in to comment.