Fix automatic module name of the change agent (fixes #29719)

quarkusio · Feb 2, 2023 · 3441e73 · 3441e73
1 parent fcb7e7b
commit 3441e73
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 6 deletions.
diff --git a/bom/application/pom.xml b/bom/application/pom.xml
@@ -462,7 +462,7 @@
             </dependency>
             <dependency>
                 <groupId>io.quarkus</groupId>
-                <artifactId>quarkus-class-change-agent</artifactId>
+                <artifactId>quarkus-klass-change-agent</artifactId>
                 <version>${project.version}</version>
             </dependency>
             <dependency>

diff --git a/core/class-change-agent/pom.xml b/core/class-change-agent/pom.xml
@@ -11,7 +11,8 @@
         <relativePath>../../build-parent/pom.xml</relativePath>
     </parent>
 
-    <artifactId>quarkus-class-change-agent</artifactId>
+    <!-- Using "klass" instead of "class", which is not allowed in automatic module name of the resulting JAR. -->
+    <artifactId>quarkus-klass-change-agent</artifactId>
     <name>Quarkus - Core - Class Change Agent</name>
     <description>
         A Java Agent that exposes the instrumentation API. This allows for super fast

diff --git a/core/deployment/pom.xml b/core/deployment/pom.xml
@@ -52,7 +52,7 @@
         </dependency>
         <dependency>
             <groupId>io.quarkus</groupId>
-            <artifactId>quarkus-class-change-agent</artifactId>
+            <artifactId>quarkus-klass-change-agent</artifactId>
         </dependency>
         <dependency>
             <groupId>io.quarkus</groupId>

diff --git a/core/runtime/pom.xml b/core/runtime/pom.xml
@@ -177,7 +177,7 @@
                         <parentFirstArtifact>org.junit.jupiter:junit-jupiter-params</parentFirstArtifact>
                         <parentFirstArtifact>org.junit.platform:junit-platform-commons</parentFirstArtifact>
                         <parentFirstArtifact>org.junit.platform:junit-platform-engine</parentFirstArtifact>
-                        <parentFirstArtifact>io.quarkus:quarkus-class-change-agent</parentFirstArtifact>
+                        <parentFirstArtifact>io.quarkus:quarkus-klass-change-agent</parentFirstArtifact>
                         <parentFirstArtifact>org.jacoco:org.jacoco.agent:runtime</parentFirstArtifact>
                         <parentFirstArtifact>io.quarkus:quarkus-bootstrap-gradle-resolver</parentFirstArtifact>
                         <parentFirstArtifact>io.quarkus:quarkus-junit5-mockito-config</parentFirstArtifact>

diff --git a/...ls/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java b/...ls/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusDev.java
@@ -538,7 +538,7 @@ private void addQuarkusDevModeDeps(GradleDevModeLauncher.Builder builder, Applic
             if (!(artifactId.getGroup().equals("io.quarkus")
                     && artifactId.getName().equals("quarkus-ide-launcher"))) {
                 if (artifactId.getGroup().equals("io.quarkus")
-                        && artifactId.getName().equals("quarkus-class-change-agent")) {
+                        && artifactId.getName().equals("quarkus-klass-change-agent")) {
                     builder.jvmArgs("-javaagent:" + appDep.getFile().getAbsolutePath());
                 } else {
                     builder.classpathEntry(ArtifactKey.of(appDep.getModuleVersion().getId().getGroup(), appDep.getName(),

diff --git a/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java b/devtools/maven/src/main/java/io/quarkus/maven/DevMojo.java
@@ -1293,7 +1293,7 @@ private void addQuarkusDevModeDeps(MavenDevModeLauncher.Builder builder, Applica
             final org.eclipse.aether.artifact.Artifact a = appDep.getArtifact();
             if (!(a.getArtifactId().equals("quarkus-ide-launcher")
                     && a.getGroupId().equals("io.quarkus"))) {
-                if (a.getArtifactId().equals("quarkus-class-change-agent")
+                if (a.getArtifactId().equals("quarkus-klass-change-agent")
                         && a.getGroupId().equals("io.quarkus")) {
                     builder.jvmArgs("-javaagent:" + a.getFile().getAbsolutePath());
                 } else {