Skip to content

Commit

Permalink
Update a few references to deprecated javax.persistence configuration
Browse files Browse the repository at this point in the history
  • Loading branch information
yrodiere committed Apr 26, 2024
1 parent 78952bc commit c44e9e1
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<property name="hibernate.archive.autodetection" value="class, hbm"/>

<property name="hibernate.dialect" value="org.hibernate.dialect.H2Dialect"/>
<property name="javax.persistence.schema-generation.database.action" value="drop-and-create"/>
<property name="jakarta.persistence.schema-generation.database.action" value="drop-and-create"/>
</properties>

</persistence-unit>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<property name="hibernate.archive.autodetection" value="class, hbm"/>

<property name="hibernate.dialect" value="org.hibernate.dialect.H2Dialect"/>
<property name="javax.persistence.schema-generation.database.action" value="drop-and-create"/>
<property name="jakarta.persistence.schema-generation.database.action" value="drop-and-create"/>
</properties>

</persistence-unit>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<properties>
<property name="hibernate.dialect" value="org.hibernate.dialect.H2Dialect"/>
<property name="javax.persistence.schema-generation.database.action" value="drop-and-create"/>
<property name="jakarta.persistence.schema-generation.database.action" value="drop-and-create"/>
</properties>

</persistence-unit>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<properties>
<property name="hibernate.dialect" value="org.hibernate.dialect.H2Dialect"/>
<property name="javax.persistence.schema-generation.database.action" value="drop-and-create"/>
<property name="jakarta.persistence.schema-generation.database.action" value="drop-and-create"/>
</properties>

</persistence-unit>
Expand Down
8 changes: 4 additions & 4 deletions integration-tests/jpa/README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,17 @@ I am doing a first pass on the properties and I want to propose the following pr
* `hibernate.dialect`
* `hibernate.show_sql` (and then `hibernate.format_sql` ?)
* should show_sql not do System.out but rather a proper log
* `javax.persistence.schema-generation.database.action`
* `jakarta.persistence.schema-generation.database.action`

Anything else?

I would force the following:

* `javax.persistence.sharedCache.mode` to yes
* `javax.persistence.sql-load-script-source` set to a default file name
* `jakarta.persistence.sharedCache.mode` to yes
* `jakarta.persistence.sql-load-script-source` set to a default file name

Questions do we need:

* `javax.persistence.transactionType`
* `jakarta.persistence.transactionType`


Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@
Optimistically create the tables;
will cause background errors being logged if they already exist,
but is practical to retain existing data across runs (or create as needed) -->
<property name="javax.persistence.schema-generation.database.action" value="drop-and-create"/>
<property name="jakarta.persistence.schema-generation.database.action" value="drop-and-create"/>

<property name="javax.persistence.validation.mode" value="NONE"/>
<property name="jakarta.persistence.validation.mode" value="NONE"/>
</properties>

</persistence-unit>
Expand Down

0 comments on commit c44e9e1

Please sign in to comment.