Quarkus spring-boot-properties extension unable to handle complex configuration. #30896

dagosec · 2023-02-05T06:41:49Z

Describe the bug

When trying to use the swedenconnect/signservice library with Quarkus and the quarkus-spring-boot-properties extension for reading the signservice configuration file
an exception is thrown. This tells us that se.swedenconnect.signservice.core.config.HandlerConfiguration must contain a no-args constructor, but this is not a class but an interface and cannot have a constructor. It seems that the spring-boot-properties extension makes a decision to run the interface through the extension's class handling code.

Expected behavior

We expected the quarkus-spring-boot-properties extension to handle the configuration the same way an actual spring-boot ConfigurationProperties annotation does. I.e, read the configuration file and setup a configuration class. This can be seen/tested in/with the signservice/demo-apps

Actual behavior

Throws

java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
        [error]: Build step io.quarkus.spring.boot.properties.deployment.ConfigurationPropertiesBuildStep#setup threw an exception: java.lang.IllegalArgumentException: Nested configuration class 'se.swedenconnect.signservice.core.config.HandlerConfiguration' must contain a no-args constructor 
        at io.quarkus.spring.boot.properties.deployment.ClassConfigurationPropertiesUtil.populateConfigObject(ClassConfigurationPropertiesUtil.java:314)
        at io.quarkus.spring.boot.properties.deployment.ClassConfigurationPropertiesUtil.populateConfigObject(ClassConfigurationPropertiesUtil.java:324)
        at io.quarkus.spring.boot.properties.deployment.ClassConfigurationPropertiesUtil.populateConfigObject(ClassConfigurationPropertiesUtil.java:324)
        at io.quarkus.spring.boot.properties.deployment.ClassConfigurationPropertiesUtil.populateConfigObject(ClassConfigurationPropertiesUtil.java:324)
        at io.quarkus.spring.boot.properties.deployment.ClassConfigurationPropertiesUtil.addProducerMethodForClassConfigProperties(ClassConfigurationPropertiesUtil.java:189)
        at io.quarkus.spring.boot.properties.deployment.ConfigurationPropertiesBuildStep.setup(ConfigurationPropertiesBuildStep.java:94)
        at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
        at java.base/java.lang.reflect.Method.invoke(Method.java:578)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:281)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
        at java.base/java.lang.Thread.run(Thread.java:1589)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)
        at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:625)
        at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:696)
        at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
        at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
        at org.junit.jupiter.api.extension.InvocationInterceptor.interceptTestClassConstructor(InvocationInterceptor.java:73)
        at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.lambda$invoke$0(InterceptingExecutableInvoker.java:93)
        at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
        at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
        at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
        at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
        at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:92)
        at org.junit.jupiter.engine.execution.InterceptingExecutableInvoker.invoke(InterceptingExecutableInvoker.java:62)
        at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeTestClassConstructor(ClassBasedTestDescriptor.java:363)
        at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.instantiateTestClass(ClassBasedTestDescriptor.java:310)
        at org.junit.jupiter.engine.descriptor.ClassTestDescriptor.instantiateTestClass(ClassTestDescriptor.java:79)
        at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.instantiateAndPostProcessTestInstance(ClassBasedTestDescriptor.java:286)
        at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$4(ClassBasedTestDescriptor.java:278)
        at java.base/java.util.Optional.orElseGet(Optional.java:364)
        at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$testInstancesProvider$5(ClassBasedTestDescriptor.java:277)
        at org.junit.jupiter.engine.execution.TestInstancesProvider.getTestInstances(TestInstancesProvider.java:31)
        at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$prepare$0(TestMethodTestDescriptor.java:105)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.prepare(TestMethodTestDescriptor.java:104)
        at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.prepare(TestMethodTestDescriptor.java:68)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$prepare$2(NodeTestTask.java:123)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.prepare(NodeTestTask.java:123)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:90)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
        at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
        at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
        at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
        at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
        at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
        at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
        at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
        at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
        at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
        at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:147)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:127)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:90)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:55)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:102)
        at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:54)
        at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
        at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:86)
        at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:86)
        at org.apache.maven.surefire.junitplatform.LazyLauncher.execute(LazyLauncher.java:55)
        at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.execute(JUnitPlatformProvider.java:223)
        at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:175)
        at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:139)
        at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
        at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
        at org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
        at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)

How to Reproduce?

A minimal Quarkus starter app with the quarkus-spring-boot-properties, quarkus-config-yaml extension and the needed swedenconnect/signservice bom and configuration can be found at dagosec/code-with-quarkus

Clone above starter app
./mvnw clean install

Output of `uname -a` or `ver`

Tested on WSL(5.15.79.1-Microsoft-standard-WSL2 x86_64 GNU/Linux) and Apple(22.2.0 Darwin Kernel Version 22.2.0)

Output of `java -version`

Tested with both java 17 and java 19

GraalVM version (if different from Java)

No response

Quarkus version or git rev

2.15.3.Final and 2.16.1.Final

Build tool (ie. output of `mvnw --version` or `gradlew --version`)

Maven 3.8.7 and Maven 3.8.6

Additional information

No response

The text was updated successfully, but these errors were encountered:

quarkus-bot · 2023-02-05T06:41:52Z

/cc @geoand (spring)

geoand · 2023-02-06T09:39:55Z

@Sgitario do you think we could improve here?

This should behave similarly that when the setter is private. In this case, the field is ignored and we write a warning saying that a field is going to be ignored. Fix quarkusio#30896

Sgitario · 2023-02-07T11:29:55Z

@Sgitario do you think we could improve here?

I think this should behave similarly to when a field has no setter or the setter is private. #30947

This should behave similarly that when the setter is private. In this case, the field is ignored and we write a warning saying that a field is going to be ignored. Fix quarkusio#30896 (cherry picked from commit 999289a)

This MR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [com.diffplug.spotless:spotless-maven-plugin](https://github.com/diffplug/spotless) | build | minor | `2.32.0` -> `2.33.0` | | [io.quarkus:quarkus-maven-plugin](https://github.com/quarkusio/quarkus) | build | patch | `2.16.1.Final` -> `2.16.2.Final` | | [io.quarkus:quarkus-universe-bom](https://github.com/quarkusio/quarkus-platform) | import | patch | `2.16.1.Final` -> `2.16.2.Final` | --- ### Release Notes <details> <summary>diffplug/spotless</summary> ### [`v2.33.0`](https://github.com/diffplug/spotless/blob/HEAD/CHANGES.md#2330---2023-01-26) ##### Added - `ProcessRunner` has added some convenience methods so it can be used for maven testing. ([#1496](diffplug/spotless#1496)) - `ProcessRunner` allows to limit captured output to a certain number of bytes. ([#1511](diffplug/spotless#1511)) - `ProcessRunner` is now capable of handling long-running tasks where waiting for exit is delegated to the caller. ([#1511](diffplug/spotless#1511)) - Allow to specify node executable for node-based formatters using `nodeExecutable` parameter ([#1500](diffplug/spotless#1500)) ##### Fixed - The default list of type annotations used by `formatAnnotations` has had 8 more annotations from the Checker Framework added [#1494](diffplug/spotless#1494) ##### Changes - **POTENTIALLY BREAKING** Bump minimum JRE from 8 to 11, next release likely to bump bytecode to Java 11 ([#1514](diffplug/spotless#1514) part 1 of [#1337](diffplug/spotless#1337)) - Rename `YamlJacksonStep` into `JacksonYamlStep` while normalizing Jackson usage ([#1492](diffplug/spotless#1492)) - Convert `gson` integration to use a compile-only source set ([#1510](diffplug/spotless#1510)). - \*\* POTENTIALLY BREAKING\*\* Removed support for KtLint 0.3x and 0.45.2 ([#1475](diffplug/spotless#1475)) - `KtLint` does not maintain a stable API - before this MR, we supported every breaking change in the API since 2019. - From now on, we will support no more than 2 breaking changes at a time. - NpmFormatterStepStateBase delays `npm install` call until the formatter is first used. This enables better integration with `gradle-node-plugin`. ([#1522](diffplug/spotless#1522)) - Bump default `ktlint` version to latest `0.48.1` -> `0.48.2` ([#1529](diffplug/spotless#1529)) - Bump default `scalafmt` version to latest `3.6.1` -> `3.7.1` ([#1529](diffplug/spotless#1529)) </details> <details> <summary>quarkusio/quarkus</summary> ### [`v2.16.2.Final`](https://github.com/quarkusio/quarkus/releases/tag/2.16.2.Final) [Compare Source](quarkusio/quarkus@2.16.1.Final...2.16.2.Final) ##### Complete changelog - [#30976](quarkusio/quarkus#30976) - Metrics - check if index contains class before attempting to use it - [#30965](quarkusio/quarkus#30965) - JandexBeanInfoAdapter.getMetricAnnotationsThroughStereotype is not null safe - [#30959](quarkusio/quarkus#30959) - Return text from /q/metrics when the Accept header contains html - [#30953](quarkusio/quarkus#30953) - Fix OIDC capability string - [#30947](quarkusio/quarkus#30947) - Ignore interface/class without default constructs fields in SB config - [#30940](quarkusio/quarkus#30940) - Use SchemaType.ARRAY instead of "ARRAY" for native support - [#30919](quarkusio/quarkus#30919) - Compilation to native fails, when quarkus-smallrye-openapi is included - [#30916](quarkusio/quarkus#30916) - Add AppCDS documentation - [#30896](quarkusio/quarkus#30896) - Quarkus spring-boot-properties extension unable to handle complex configuration. - [#30878](quarkusio/quarkus#30878) - Bump postgresql from 42.5.2 to 42.5.3 - [#30866](quarkusio/quarkus#30866) - Only run the quickstart compilation for main - [#30851](quarkusio/quarkus#30851) - Fixed return type typo in smallrye graphQL guide - [#30844](quarkusio/quarkus#30844) - Fixed greeting in getting started guide - [#30839](quarkusio/quarkus#30839) - Fix handling of Accept header in graphQL - [#30833](quarkusio/quarkus#30833) - Update docs to show BuildProducer use as method parameter instead of field - [#30828](quarkusio/quarkus#30828) - Make OIDC session cookie same site lax by default - [#30826](quarkusio/quarkus#30826) - Caffeine - Automatically register metrics cache impls if Micrometer is around - [#30825](quarkusio/quarkus#30825) - Fix comment about Caffeine optimization - [#30823](quarkusio/quarkus#30823) - Change accept header to valid plain text in micrometer documentation - [#30821](quarkusio/quarkus#30821) - Packaging type -Dquarkus.package.create-appcds=true isn't documented - [#30815](quarkusio/quarkus#30815) - Update SmallRye Config to 2.13.2 - [#30812](quarkusio/quarkus#30812) - Manage the apache-mime4j dependency - [#30806](quarkusio/quarkus#30806) - */* in Accept header is ignored if not listed as the first item - [#30805](quarkusio/quarkus#30805) - MailTemplateInstance with attachments - [#30803](quarkusio/quarkus#30803) - Support file and byte array attachments in `MailTemplateInstance` - [#30797](quarkusio/quarkus#30797) - OIDC login not work - [#30783](quarkusio/quarkus#30783) - <artifactId> uses 'quarkus.platform.artifact-id' property - [#30778](quarkusio/quarkus#30778) - Avoid creating 3 Liquibase MongoDB instances for startup operations - [#30776](quarkusio/quarkus#30776) - Ensure that AwsProxyRequestContext can be used with [@Context](https://github.com/Context) in RESTEasy Reactive - [#30767](quarkusio/quarkus#30767) - Remove duplicate notification of SseBroadcaster's onErrorListeners - [#30765](quarkusio/quarkus#30765) - Bump postgresql from 42.5.1 to 42.5.2 - [#30755](quarkusio/quarkus#30755) - Update ForwardedParser to validate the port - [#30744](quarkusio/quarkus#30744) - \[Quarkus Native] ClassNotFoundException: com.github.benmanes.caffeine.cache.SSSW - [#30536](quarkusio/quarkus#30536) - munitnyucontextmanager non helpful error reporting - [#29753](quarkusio/quarkus#29753) - Introduce ConnectionFactoryWrapperBuildItem - [#29605](quarkusio/quarkus#29605) - Update docs to reflect that injection should not - [#27774](quarkusio/quarkus#27774) - PLANNER-1709 Avoid deprecated penalize/reward overloads - [#23442](quarkusio/quarkus#23442) - problem using quarkus-resteasy-reactive-kotlin-serialization with AwsProxyRequestContext </details> <details> <summary>quarkusio/quarkus-platform</summary> ### [`v2.16.2.Final`](quarkusio/quarkus-platform@2.16.1.Final...2.16.2.Final) [Compare Source](quarkusio/quarkus-platform@2.16.1.Final...2.16.2.Final) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

dagosec added the kind/bug Something isn't working label Feb 5, 2023

quarkus-bot bot added the area/spring Issues relating to the Spring integration label Feb 5, 2023

Sgitario mentioned this issue Feb 7, 2023

Ignore interface/class without default constructs fields in SB config #30947

Merged

geoand closed this as completed in #30947 Feb 7, 2023

quarkus-bot bot added this to the 3.0 - main milestone Feb 7, 2023

gsmet modified the milestones: 3.0 - main, 2.16.2.Final Feb 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Quarkus spring-boot-properties extension unable to handle complex configuration. #30896

Quarkus spring-boot-properties extension unable to handle complex configuration. #30896

dagosec commented Feb 5, 2023 •

edited by geoand

Loading

quarkus-bot bot commented Feb 5, 2023

geoand commented Feb 6, 2023

Sgitario commented Feb 7, 2023

Quarkus spring-boot-properties extension unable to handle complex configuration. #30896

Quarkus spring-boot-properties extension unable to handle complex configuration. #30896

Comments

dagosec commented Feb 5, 2023 • edited by geoand Loading

Describe the bug

Expected behavior

Actual behavior

How to Reproduce?

Output of uname -a or ver

Output of java -version

GraalVM version (if different from Java)

Quarkus version or git rev

Build tool (ie. output of mvnw --version or gradlew --version)

Additional information

quarkus-bot bot commented Feb 5, 2023

geoand commented Feb 6, 2023

Sgitario commented Feb 7, 2023

dagosec commented Feb 5, 2023 •

edited by geoand

Loading

Output of `uname -a` or `ver`

Output of `java -version`

Build tool (ie. output of `mvnw --version` or `gradlew --version`)