Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The reactive REST client does not support P12, PEM and CRT/KEY files #38811

Open
cescoffier opened this issue Feb 16, 2024 · 4 comments
Open
Assignees
Labels

Comments

@cescoffier
Copy link
Member

Description

The reactive rest client only supports the JKS format at the moment. While this format is popular in the Java world, it's not popular (at all) anywhere else. CRT/KEY, PEM (the same as CRT/KEY), and P12 (PFX) are more popular.

Implementation ideas

The underlying HTTP client has support for these other formats, so this enhancement is about:

  • adding the configuration key to pass the certificate and key files
  • detect the format (based on the extension)
  • configure the underlying client

Note that his work will enable the proper support of certificate reloading (it can be implemented with JKS, but most use case are about the other formats)

@cescoffier cescoffier added the kind/enhancement New feature or request label Feb 16, 2024
Copy link

quarkus-bot bot commented Feb 16, 2024

/cc @geoand (rest-client)

geoand added a commit to geoand/quarkus that referenced this issue Feb 16, 2024
geoand added a commit to geoand/quarkus that referenced this issue Feb 16, 2024
geoand added a commit to geoand/quarkus that referenced this issue Feb 16, 2024
@geoand geoand self-assigned this Feb 16, 2024
geoand added a commit to geoand/quarkus that referenced this issue Feb 16, 2024
geoand added a commit to geoand/quarkus that referenced this issue Feb 16, 2024
geoand added a commit to geoand/quarkus that referenced this issue Feb 16, 2024
geoand added a commit to geoand/quarkus that referenced this issue Feb 16, 2024
geoand added a commit to geoand/quarkus that referenced this issue Feb 19, 2024
@winks
Copy link

winks commented May 2, 2024

Just stumbled over this and seeing geoand@7414953#diff-d374086457a41b4c533e9ff072d61977ce886022ded6173e358b6441b5f9c410R264 (I assume it's not merged and still being worked on) I just want to add that the quarkus reactive mailer seems to use "PKCS" as the truststore.type value and not PKCS12.

As I have no clue about quarkus internal consistency policies I'm just leaving this as a heads up here.

@geoand
Copy link
Contributor

geoand commented May 2, 2024

@cescoffier is working on a massive revamp of this

@cescoffier
Copy link
Member Author

Yes, and the mailer is one of the components that will benefit from this large refactoring/ centralization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants