Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ResteasyReactiveOutputStream so that it can be used by Quarkus CXF #40994

Closed
ppalaga opened this issue Jun 5, 2024 · 0 comments · Fixed by #40995
Closed

Refactor ResteasyReactiveOutputStream so that it can be used by Quarkus CXF #40994

ppalaga opened this issue Jun 5, 2024 · 0 comments · Fixed by #40995
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Jun 5, 2024

Description

ResteasyReactiveOutputStream was written so that RESTeasy is able to run on top of Vert.x.
CXF works like RESTeasy: it also writes to a (Servlet)OutputStream and to make CXF able to run on top of Vert.x one needs a similar class. For some time, we had an adjusted static copy of ResteasyReactiveOutputStream in Quarkus CXF. At some point, we got issues related to chunking reported, that were fixed in Quarkus long time ago.
After that, I implemented a script that adapts ResteasyReactiveOutputStream.java at Quarkus CXF runtime which is a bit safer, but still rather fragile.

Implementation ideas

Hence, it would be nice if ResteasyReactiveOutputStream could be refactored in the following way:

  • Make it independent of RESTeasy
  • Possibly move it (along with its ancillary classes) to a separate module in Quarkus that depends only on vertx-web but does not depend on RESTeasy
  • Or perhaps move the reafctored classes to Vert.x

@cescoffier encouraged me to prepare a PR which is underway.

@ppalaga ppalaga added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Jun 5, 2024
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jun 5, 2024
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jun 6, 2024
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jun 10, 2024
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jun 10, 2024
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jun 10, 2024
ppalaga added a commit to ppalaga/quarkus that referenced this issue Jun 11, 2024
@quarkus-bot quarkus-bot bot added this to the 3.12 - main milestone Jun 11, 2024
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
danielsoro pushed a commit to danielsoro/quarkus that referenced this issue Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant