Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vert.x Http: application/json MIME not compressed by default #41094

Closed
Karm opened this issue Jun 10, 2024 · 1 comment · Fixed by #43497
Closed

Vert.x Http: application/json MIME not compressed by default #41094

Karm opened this issue Jun 10, 2024 · 1 comment · Fixed by #43497
Assignees
Labels
area/vertx kind/enhancement New feature or request
Milestone

Comments

@Karm
Copy link
Member

Karm commented Jun 10, 2024

Describe the bug

As discovered in #40750

application/json and application/xhtml+xml MIMEs are not compressed by default.

See HttpBuildTimeConfig.java.

@mkouba, was there a specific reason for not including it? It seems in the log that you originated it in 670a205

I left the default intact in #40750, merely documenting it.

Expected behavior

Major MIME like application/json gets compressed.

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

3.8.4, main

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@Karm Karm added the kind/bug Something isn't working label Jun 10, 2024
@Karm Karm changed the title Vert.x Http: application/json, application/xhtml+xml MIMEs not compressed by default Vert.x Http: application/json MIME not compressed by default Jun 10, 2024
@Karm Karm self-assigned this Jun 10, 2024
@mkouba
Copy link
Contributor

mkouba commented Jun 10, 2024

application/json and application/xhtml+xml MIMEs are not compressed by default.

I can't remember any particular reason. We probably just wanted to keep the initial list small and nobody raised the hand so 🤷.

Feel free to send a PR.

It would be kind of a breaking change so a note in the migration guide would be needed.

@Karm Karm added kind/enhancement New feature or request and removed kind/bug Something isn't working labels Jun 12, 2024
@jponge jponge self-assigned this Sep 25, 2024
jponge added a commit to jponge/quarkus that referenced this issue Sep 25, 2024
@quarkus-bot quarkus-bot bot added this to the 3.16 - main milestone Sep 26, 2024
mskacelik pushed a commit to mskacelik/quarkus that referenced this issue Sep 27, 2024
bschuhmann pushed a commit to bschuhmann/quarkus that referenced this issue Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertx kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants