Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualThreadExtension does not take super classes into account #41782

Closed
bdeneuter opened this issue Jul 9, 2024 · 3 comments · Fixed by #41900
Closed

VirtualThreadExtension does not take super classes into account #41782

bdeneuter opened this issue Jul 9, 2024 · 3 comments · Fixed by #41900
Labels
area/virtual-threads Issue related to Java's Virtual Threads kind/bug Something isn't working
Milestone

Comments

@bdeneuter
Copy link
Contributor

Describe the bug

A lot of our test classes have a single super class which contains the @ShouldNotPin annotation. The class VirtualThreadExtension does not take super classes into account when determing if recording is needed:
https://github.com/quarkusio/quarkus/blob/main/independent-projects/junit5-virtual-threads/src/main/java/io/quarkus/test/junit5/virtual/internal/VirtualThreadExtension.java#L65

Expected behavior

When a super class declares the @ShouldNotPin annotation that the extension validates that no pinning occurs.

Actual behavior

The @ShouldNotPin annotation is ignored

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

@bdeneuter bdeneuter added the kind/bug Something isn't working label Jul 9, 2024
@geoand geoand added area/virtual-threads Issue related to Java's Virtual Threads and removed triage/needs-triage labels Jul 10, 2024
@quarkus-bot
Copy link

quarkus-bot bot commented Jul 10, 2024

/cc @cescoffier (virtual-threads), @ozangunalp (virtual-threads)

@cescoffier
Copy link
Member

Fancy a PR as you found the place where we need to check for the super class?

@bdeneuter
Copy link
Contributor Author

Yes, of course. When I find the time I will create the PR

bdeneuter pushed a commit to bdeneuter/quarkus that referenced this issue Jul 15, 2024
Allow the usage of @ShouldPin and @ShouldNotPin on super classes
bdeneuter added a commit to bdeneuter/quarkus that referenced this issue Jul 15, 2024
Fix for quarkusio#41782
Allow the usage of @ShouldPin and @ShouldNotPin on super classes
bdeneuter added a commit to bdeneuter/quarkus that referenced this issue Jul 15, 2024
Fix for quarkusio#41782
Allow the usage of @ShouldPin and @ShouldNotPin on super classes
bdeneuter added a commit to bdeneuter/quarkus that referenced this issue Jul 15, 2024
Fix for quarkusio#41782
Allow the usage of @ShouldPin and @ShouldNotPin on super classes
bdeneuter added a commit to bdeneuter/quarkus that referenced this issue Jul 16, 2024
Fix for quarkusio#41782
Allow the usage of @ShouldPin and @ShouldNotPin on super classes
bdeneuter added a commit to bdeneuter/quarkus that referenced this issue Jul 16, 2024
Fix for quarkusio#41782
Allow the usage of @ShouldPin and @ShouldNotPin on super classes
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 19, 2024
barreiro pushed a commit to barreiro/quarkus that referenced this issue Jul 25, 2024
Fix for quarkusio#41782
Allow the usage of @ShouldPin and @ShouldNotPin on super classes
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
Fix for quarkusio#41782
Allow the usage of @ShouldPin and @ShouldNotPin on super classes
danielsoro pushed a commit to danielsoro/quarkus that referenced this issue Sep 20, 2024
Fix for quarkusio#41782
Allow the usage of @ShouldPin and @ShouldNotPin on super classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/virtual-threads Issue related to Java's Virtual Threads kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants