Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PostgresQL IT tests failing with Mandrel 24.2 (for JDK 24) #41917

Closed
zakkak opened this issue Jul 16, 2024 · 2 comments · Fixed by #41935
Closed

PostgresQL IT tests failing with Mandrel 24.2 (for JDK 24) #41917

zakkak opened this issue Jul 16, 2024 · 2 comments · Fixed by #41935
Assignees
@zakkak
Labels
area/native-image kind/bug Something isn't working
Milestone
3.14.0.CR1

Comments

@zakkak
Copy link
Contributor

zakkak commented Jul 16, 2024

Describe the bug

Integration tests:

  • JPA - PostgreSQL
  • JPA - PostgreSQL with XML

fail with the latest mandrel builds (for JDK 24)

Expected behavior

Tests should pass

Actual behavior

 Error:  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.111 s <<< FAILURE! -- in io.quarkus.it.jpa.postgresql.JPAFunctionalityInGraalITCase
Error:  io.quarkus.it.jpa.postgresql.JPAFunctionalityInGraalITCase.verifyJdkXmlParsersHavebeenEcludedFromNative -- Time elapsed: 0.083 s <<< FAILURE!
org.opentest4j.AssertionFailedError: Type 'org.postgresql.jdbc.PgSQLXML' was not found in the report in target/quarkus-integration-test-jpa-postgresql-999-SNAPSHOT-native-image-source-jar/reports/used_classes_quarkus-integration-test-jpa-postgresql-999-SNAPSHOT-runner_20240716_005849.txt
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:38)
	at org.junit.jupiter.api.Assertions.fail(Assertions.java:138)
	at io.quarkus.test.junit.nativeimage.ClassInclusionReport.assertContains(ClassInclusionReport.java:59)
	at io.quarkus.test.junit.nativeimage.ClassInclusionReport.assertContains(ClassInclusionReport.java:49)
	at io.quarkus.it.jpa.postgresql.JPAFunctionalityInGraalITCase.verifyJdkXmlParsersHavebeenEcludedFromNative(JPAFunctionalityInGraalITCase.java:21)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestMethod(QuarkusTestExtension.java:812)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

See https://github.com/graalvm/mandrel/actions/runs/9948658053/job/27484292339

How to Reproduce?

./mvnw -Dnative -pl integration-tests/jpa-postgresql-withxml,integration-tests/jpa-postgresql -Dnative.surefire.skip -Dformat.skip -Dno-descriptor-tests clean package

Output of uname -a or ver

No response

Output of java -version

No response

Mandrel or GraalVM version (if different from Java)

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response
@zakkak zakkak added kind/bug Something isn't working area/native-image labels Jul 16, 2024
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jul 16, 2024

/cc @Karm (mandrel), @galderz (mandrel)

@zakkak zakkak mentioned this issue Jul 16, 2024
Open
@zakkak
Copy link
Contributor Author

zakkak commented Jul 16, 2024

Bisecting indicated that the regression was introduced by oracle/graal@1d769c7

Looking into it...

@zakkak zakkak self-assigned this Jul 16, 2024
@zakkak zakkak mentioned this issue Jul 16, 2024
Merged
zakkak added a commit to zakkak/quarkus that referenced this issue Jul 16, 2024
@zakkak
Handle new format of used_classes_* reports in GraalVM for JDK 24
e849b75 
Starting with GraalVM for JDK 24 the format of the report has changed
prefixing each line with the class loader name and a colon, e.g.:

GraalVM for JDK 22 (and 23 which is not released yet):
```
org.postgresql.jdbc.PgSQLXML
```

GraalVM for JDK 24:
```
com.oracle.svm.hosted.NativeImageClassLoader:org.postgresql.jdbc.PgSQLXML
```

Closes quarkusio#41917
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 17, 2024
barreiro pushed a commit to barreiro/quarkus that referenced this issue Jul 25, 2024
@zakkak @barreiro
Handle new format of used_classes_* reports in GraalVM for JDK 24
5c622e5 
Starting with GraalVM for JDK 24 the format of the report has changed
prefixing each line with the class loader name and a colon, e.g.:

GraalVM for JDK 22 (and 23 which is not released yet):
```
org.postgresql.jdbc.PgSQLXML
```

GraalVM for JDK 24:
```
com.oracle.svm.hosted.NativeImageClassLoader:org.postgresql.jdbc.PgSQLXML
```

Closes quarkusio#41917
holly-cummins pushed a commit to holly-cummins/quarkus that referenced this issue Jul 31, 2024
@zakkak @holly-cummins
Handle new format of used_classes_* reports in GraalVM for JDK 24
f2cb542 
Starting with GraalVM for JDK 24 the format of the report has changed
prefixing each line with the class loader name and a colon, e.g.:

GraalVM for JDK 22 (and 23 which is not released yet):
```
org.postgresql.jdbc.PgSQLXML
```

GraalVM for JDK 24:
```
com.oracle.svm.hosted.NativeImageClassLoader:org.postgresql.jdbc.PgSQLXML
```

Closes quarkusio#41917
danielsoro pushed a commit to danielsoro/quarkus that referenced this issue Sep 20, 2024
@zakkak @danielsoro
Handle new format of used_classes_* reports in GraalVM for JDK 24
085ee7f 
Starting with GraalVM for JDK 24 the format of the report has changed
prefixing each line with the class loader name and a colon, e.g.:

GraalVM for JDK 22 (and 23 which is not released yet):
```
org.postgresql.jdbc.PgSQLXML
```

GraalVM for JDK 24:
```
com.oracle.svm.hosted.NativeImageClassLoader:org.postgresql.jdbc.PgSQLXML
```

Closes quarkusio#41917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zakkak zakkak

Labels
area/native-image kind/bug Something isn't working
Projects
None yet
Milestone
3.14.0.CR1
Development

Successfully merging a pull request may close this issue.

Handle new format of used_classes_* reports in GraalVM for JDK 24 zakkak/quarkus
1 participant
@zakkak