Panache for Hibernate ORM assumes the datasource has the same name as the persistence unit

[yrodiere]

Describe the bug

See this code:

quarkus/extensions/panache/hibernate-orm-panache-common/runtime/src/main/java/io/quarkus/hibernate/orm/panache/common/runtime/AbstractJpaOperations.java

Lines 87 to 92 in 742f226

	if (!arcContainer.instance(AgroalDataSource.class,
	new DataSource.DataSourceLiteral(persistentUnitName)).isAvailable()) {
	throw new IllegalStateException(
	"The named datasource '" + persistentUnitName
	+ "' has not been properly configured. See https://quarkus.io/guides/datasource#multiple-datasources for information on how to do that.");
	}

new DataSource.DataSourceLiteral(persistentUnitName) <= What is going on here?!

As a reminder, the name of the datasource can be completely different from the name of the persistence unit.

@geoand seems this is yours; is there such a thing as too much Monster Energy? 🤔

From what I can see this was introduced to "Provide actionable information when EntityManager is not available in Hibernate Panache". Not sure why this would involve looking up the datasource...

Expected behavior

No response

Actual behavior

No response

How to Reproduce?

No response

Output of uname -a or ver

No response

Output of java -version

No response

Quarkus version or git rev

No response

Build tool (ie. output of mvnw --version or gradlew --version)

No response

Additional information

No response

[quarkus-bot]

/cc @FroMage (panache), @gsmet (hibernate-orm), @loicmathieu (panache)

[geoand]

is there such a thing as too much Monster Energy? 🤔

There is not

[geoand]

I need to have a look because I obviously have no idea recollection of me adding this (thank goodness for git)

[geoand]

I think we can safely just drop that check