-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimpleJsonWithReflectionFreeSerializersTest is apparently a bit flaky #43104
Comments
/cc @mariofusco |
/cc @geoand (jackson), @mariofusco (jackson) |
Thanks for bringing this up. I also saw it fail in an unrelated PR |
This will help in debugging quarkusio#43104
Thanks of having reported this, I am giving a look. For now I just noticed that |
It is yeah, because what is being tested here is that the custom serialization via |
Ok, so if I'm understanding correctly, when run from |
Right, I can't reproduce it either, which is why I opened #43124 so next time it happens on CI, we can at least have a little more info on what it trying to be serialized |
Is there any special situation that happens only on CI machines? E.g. are the tests executed in parallel there while they are always sequential on our development machines? |
Not that I remember |
@mariofusco the only thing that is specific to CI is that the machines are slow (both CPU and IO). |
Giving a second look at the reported error I believe that the first part (the one where @geoand added the better error message, that is useful anyway) is a red herring. It is just the exception that, as discussed before, is expected and always thrown. The only actual error that is making CI to fail is the second part, but at the moment I still don't know what it is causing it.
|
Nope, I take this back and also that second error message is in reality expected as it is raised by |
Found, the error is in |
🙏🏽 |
@mariofusco can we close this in light of your latest fixes? |
I think this can be closed. |
👍🏽 |
This will help in debugging quarkusio#43104
This will help in debugging quarkusio#43104
We had a test failure for
SimpleJsonWithReflectionFreeSerializersTest
in #43079 :The text was updated successfully, but these errors were encountered: