Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that one can override runtime properties via config/application.properties #4452

Closed
emmanuelbernard opened this issue Oct 8, 2019 · 11 comments · Fixed by #4458
Closed
Assignees
Milestone

Comments

@emmanuelbernard
Copy link
Member

You can override runtime properties in bulk by placing a config/application.properties int he working directory of the application.
This is useful for users but not documented.

#1218 (comment)
https://github.com/geoand/quarkus/blob/46dc078de494b331d83d39df8dddcc97e516bf85/core/runtime/src/main/java/io/quarkus/runtime/configuration/ApplicationPropertiesConfigSource.java#L70

No reference in https://quarkus.io/guides/application-configuration-guide

@emmanuelbernard emmanuelbernard added this to the 0.25.0 milestone Oct 8, 2019
@geoand geoand self-assigned this Oct 9, 2019
geoand added a commit to geoand/quarkus that referenced this issue Oct 9, 2019
geoand added a commit to geoand/quarkus that referenced this issue Oct 9, 2019
@flo-ryan
Copy link

flo-ryan commented Oct 9, 2019

Thank you for adding this to the documentation!

When running quarkus:dev the "config" folder needs to be inside target/classes, however the hot code replacement (?) seems to get rid of it.

Could maybe also add how to deal with this for quarkus:dev? Or am I missing something?

@geoand
Copy link
Contributor

geoand commented Oct 9, 2019

Let me check and see how quarkus:dev behaves with this feature.

@geoand
Copy link
Contributor

geoand commented Oct 9, 2019

I just checked and quarkus:dev works file with this feature. I will add a note however in #4458 on how to use it.

geoand added a commit to geoand/quarkus that referenced this issue Oct 9, 2019
@geoand
Copy link
Contributor

geoand commented Oct 9, 2019

Note added in #4458 about dev mode

gsmet added a commit that referenced this issue Oct 9, 2019
Document the use of config/application.properties
@gsmet gsmet modified the milestones: 0.25.0, 0.24.0 Oct 9, 2019
@flo-ryan
Copy link

Is there a list or similar of runtime properties? Or some other way to find out which properties are build and which are runtime? Thanks!

@geoand
Copy link
Contributor

geoand commented Oct 10, 2019

Is there a list or similar of runtime properties? Or some other way to find out which properties are build and which are runtime? Thanks!

@machi1990 @gsmet I think this one is for you

@emmanuelbernard
Copy link
Member Author

@flo-ryan it should be describe in each relevant guide. We are also in the process of rolling out a unified rendering of the property list. See Hibernate ORM's for example, you will see the different icon depending on the lifecycle (build time vs runtime) see https://quarkus.io/guides/hibernate-orm-guide#properties-to-refine-your-hibernate-orm-configuration

PS @gsmet should we rename the lifecycle column to build/runtime to be a bit more specific?

@flo-ryan
Copy link

@emmanuelbernard A unified list of all available properties (for all microprofiles?) including the build/runtime info would be very helpful and highly appreciated! Thanks!

@emmanuelbernard
Copy link
Member Author

@kenfinnigan we don't have a MP list of properties right in the Quarkus guides? I also felt we would be better with the list described. whether unified or in each guide, I personally was leaning towards each guide.

@flo-ryan
Copy link

For example: It is unclear to me if/how I can set user + password + roles at runtime using "quarkus.security.embedded.*" in application.properties in a "config" folder (to be able to set user passwords more securely at runtime).

@emmanuelbernard
Copy link
Member Author

CC @sberyozkin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants