add GradleRunIntegrationTest (incl. QuarkusJavaLauncher) #1986

vorburger · 2019-04-10T16:20:29Z

This fixes #1623

It uses https://github.com/vorburger/ch.vorburger.exec#advantages

vorburger · 2019-04-11T12:24:39Z

@stalep FYI this may actually help to understand the cause of the build failure in #1985 better (because {my} exec util logs much more than j.l.Process), so unless there are strong objections to the inclusion of that 3rd party lib, I think this provides real value.

I'll therefore ASAP rebase this based on recent merge (of #1993 and #1929) - let's see if we get more details about the failure (only) on Azure with this...

stalep · 2019-04-11T13:09:00Z

I'm just not sure the reason to add another dependency for this (which contain other dependencies :) other than just for logging. What kind of output is omitted when using standard Process vs your impl?

vorburger · 2019-04-11T13:31:36Z

What kind of output is omitted when using standard Process vs your impl?

There simply is no output at all... 😈 it would, of course, be possible to re-implement the equivalent, but (to me) this seems to belong in some library - which is, years ago, I built https://github.com/vorburger/ch.vorburger.exec, and am happy to also offer it to Quarkus... 😸 See also https://github.com/vorburger/ch.vorburger.exec#advantages. (BTW: I'm happy to "donate" it under some JBoss.org repo, if there is interest, or accept other committers to the project.)

help to understand the cause of the build failure in #1985 better
see if we get more details about the failure (only) on Azure with this...

And indeed it does!! FTR, locally it's like this:

[INFO] Running io.quarkus.gradle.it.GradleRunIntegrationTest
[main] INFO ch.vorburger.exec.ManagedProcess - Starting Program [java, -jar, ../gradle-it/build/gradle-it-runner.jar] (in working directory /home/vorburger/Quarkus/git/quarkus/devtools/gradle-it-run/.)
[Exec Stream Pumper] INFO ch.vorburger.exec.ManagedProcess - java: 2019-04-11 12:32:17,896 INFO  [io.quarkus] (main) Quarkus 999-SNAPSHOT started in 3.055s. Listening on: http://[::]:8080
[Exec Stream Pumper] INFO ch.vorburger.exec.ManagedProcess - java: 2019-04-11 12:32:18,007 INFO  [io.quarkus] (main) Installed features: [cdi, resteasy]
[main] INFO ch.vorburger.exec.ManagedProcess - Successfully destroyed Program [java, -jar, ../gradle-it/build/gradle-it-runner.jar] (in working directory /home/vorburger/Quarkus/git/quarkus/devtools/gradle-it-run/.)
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.591 s - in io.quarkus.gradle.it.GradleRunIntegrationTest

on the Azure build it's like this:

[INFO] Running io.quarkus.gradle.it.GradleRunIntegrationTest
[main] INFO ch.vorburger.exec.ManagedProcess - Starting Program [java, -jar, ../gradle-it/build/gradle-it-runner.jar] (in working directory /home/vsts/work/1/s/devtools/gradle-it-run/.)
[main] INFO ch.vorburger.exec.ManagedProcess - Successfully destroyed Program [java, -jar, ../gradle-it/build/gradle-it-runner.jar] (in working directory /home/vsts/work/1/s/devtools/gradle-it-run/.)
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.494 s <<< FAILURE! - in io.quarkus.gradle.it.GradleRunIntegrationTest
[ERROR] testHelloEndpoint  Time elapsed: 1.479 s  <<< ERROR!
java.net.ConnectException: Connection refused (Connection refused)

I now see the problem - and will ASAP amend this PR with what I think will fix it...

vorburger · 2019-04-11T14:55:16Z

The build failure (above) on the Build_JDK11_Linux Job is due to #2012 ... @stalep BTW this underlines how important it is to run tests like this and be able to see the output from the externally launched process. If this new GradleRunIntegrationTest, and more like it in the future (e.g. #2005) were to use only simple j.l.ProcessBuilder directly, it would be almost impossible to make sense of a test failure like the #2012 problem (trust me, I've been there, in MariaDB4j).

stalep · 2019-04-12T13:11:43Z

hm, the windows build failed again.

vorburger · 2019-04-12T13:32:21Z

hm, the windows build failed again

not just the Windows build but the Java 11 one as well 😢 see #2036, for some reason the built JAR is bad, it has INFO [io.quarkus] (main) Installed features: [] instead of [cdi, resteasy] - but I've no clue what could cause this, on the Azure build; works fine locally!

geoand · 2019-04-12T15:00:53Z

I also tried this PR locally with both Java 8 and Java 11 and it worked.

vorburger · 2019-04-29T13:17:34Z

@stalep @cescoffier @aloubyansky @gsmet @stuartwdouglas I'd love for this work to be able to be merged, but am quite clueless as to why the Gradle build produces a JAR with empty Installed Features - and thus fails this new IT, but only on the Azure build; it works locally, for me, @geoand and (I think) @stalep.

I'm happy to rebase this once - if someone can then help to investigate the build failure further?

stuartwdouglas · 2019-05-31T01:42:47Z

devtools/gradle-it-run/pom.xml

+        <maven.deploy.skip>true</maven.deploy.skip>
+    </properties>
+
+    <dependencies>


This does not have a dependency on quarkus-gradle-plugin-integration-test so its possible this can run before the jar it depends on is built.

@stuartwdouglas that's a good point, I've added a dependency now - am curious if this helps to get this PR to finally pass on the Azure build server as well (and not just locally, as it always has)

cescoffier · 2019-06-07T06:25:50Z

I'm a bit worried about this PR pending for so long. @stalep when you have a few minutes can you tell me the current state?

This reverts commit 20ecd1b.

vorburger · 2019-06-10T20:32:01Z

#2214 removed the devtools/gradle-it which this is based on, so that has to come back for this...

see https://github.com/vorburger/ch.vorburger.exec#advantages

This should fix the test failure on slow CI servers such as Azure Build.

…rkusio#2012) This should fix the test failure on environments where the wrong `java` is on the `PATH`, such as in Azure; for details, see microsoft/azure-pipelines-tasks#10103.

…ild order

vorburger · 2019-06-10T21:33:19Z

#2214 removed the devtools/gradle-it which this is based on, so that has to come back for this...

taken care of in #2783

cescoffier added the needs-rebase label 4 days ago

Rebase done (based on / assuming #2783, which is included here)

tell me the current state?

It used to build fine locally and fail (only) on the Azure build; let's see if it's better now...

emmanuelbernard · 2019-06-26T14:56:17Z

Ping @stalep

dmlloyd · 2019-07-10T19:32:35Z

Ping x2 @stalep? I'll fire off a more recent CI but it would be good to get a review on this.

dmlloyd · 2019-07-10T19:39:50Z

Never mind: I don't have permissions to re-queue a successful build. Also the build is so old that it has disappeared off Azure. So I guess... maybe force-push it one more time?

geoand · 2019-07-10T19:42:35Z

Is this superceded by #2783 ?

emmanuelbernard · 2019-11-12T13:38:05Z

This one is likely very outdated. I'm going to close it. Open it again if I'm incorrect.

vorburger force-pushed the issue-1623_actually-add-gradle-it-run_ch.vorburger.exec branch from 00d389b to 73a9117 Compare April 10, 2019 17:12

stalep mentioned this pull request Apr 11, 2019

use 'plugins' instead of 'apply plugin' in gradle-it #1926

Closed

vorburger mentioned this pull request Apr 11, 2019

add GradleRunIntegrationTest (fixes #1623) #1985

Closed

vorburger force-pushed the issue-1623_actually-add-gradle-it-run_ch.vorburger.exec branch from 73a9117 to cb3092f Compare April 11, 2019 12:32

This was referenced Apr 11, 2019

Add tests for the startup log output #2005

Closed

Azure DevOps Build_JDK11_Linux Job build should set PATH for java 11 instead of 8 binary to be used #2012

Closed

vorburger force-pushed the issue-1623_actually-add-gradle-it-run_ch.vorburger.exec branch from 8836a9e to d2ce2ea Compare April 12, 2019 12:42

vorburger mentioned this pull request Apr 12, 2019

Gradle IT built Quarkus JARs have Installed features: [] when built on Azure CI (but work locally) #2036

Closed

vorburger changed the title ~~use exec util instead of raw ProcessBuilder in GradleRunIntegrationTest~~ add GradleRunIntegrationTest (incl. QuarkusJavaLauncher) Apr 12, 2019

stuartwdouglas reviewed May 31, 2019

View reviewed changes

cescoffier added the triage/needs-rebase This PR needs to be rebased first because it has merge conflicts label Jun 7, 2019

Revert "remove gradle-it, need a better approach"

71a9a13

This reverts commit 20ecd1b.

vorburger mentioned this pull request Jun 10, 2019

Gradle build fails if there is no src/main/resources/META-INF/resources/ #2782

Closed

vorburger added 6 commits June 10, 2019 22:52

add src/main/resources to gradle-it to work around bug quarkusio#2782

86d1440

add GradleRunIntegrationTest (fixes quarkusio#1623)

c3984bb

use exec util instead of raw ProcessBuilder in GradleRunIntegrationTest

6864c35

see https://github.com/vorburger/ch.vorburger.exec#advantages

make GradleRunIntegrationTest wait for "Listening on: http"

b6752a2

This should fix the test failure on slow CI servers such as Azure Build.

new QuarkusJavaLauncher which takes JAVA_HOME into account (fixes qua…

a4bcc40

…rkusio#2012) This should fix the test failure on environments where the wrong `java` is on the `PATH`, such as in Azure; for details, see microsoft/azure-pipelines-tasks#10103.

add explicit dependency from gradle-it-run/ to gradle-it/ to force bu…

bac56cc

…ild order

vorburger force-pushed the issue-1623_actually-add-gradle-it-run_ch.vorburger.exec branch from d2ce2ea to bac56cc Compare June 10, 2019 21:32

vorburger mentioned this pull request Jun 27, 2019

Add support for running integration tests from Gradle #2993

Closed

emmanuelbernard closed this Nov 12, 2019

gsmet added the triage/out-of-date This issue/PR is no longer valid or relevant label Nov 15, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add GradleRunIntegrationTest (incl. QuarkusJavaLauncher) #1986

add GradleRunIntegrationTest (incl. QuarkusJavaLauncher) #1986

vorburger commented Apr 10, 2019 •

edited

Loading

vorburger commented Apr 11, 2019 •

edited

Loading

stalep commented Apr 11, 2019

vorburger commented Apr 11, 2019

vorburger commented Apr 11, 2019

stalep commented Apr 12, 2019

vorburger commented Apr 12, 2019

geoand commented Apr 12, 2019

vorburger commented Apr 29, 2019

stuartwdouglas May 31, 2019

vorburger Jun 10, 2019

cescoffier commented Jun 7, 2019

vorburger commented Jun 10, 2019

vorburger commented Jun 10, 2019

emmanuelbernard commented Jun 26, 2019

dmlloyd commented Jul 10, 2019

dmlloyd commented Jul 10, 2019

geoand commented Jul 10, 2019

emmanuelbernard commented Nov 12, 2019

add GradleRunIntegrationTest (incl. QuarkusJavaLauncher) #1986

add GradleRunIntegrationTest (incl. QuarkusJavaLauncher) #1986

Conversation

vorburger commented Apr 10, 2019 • edited Loading

vorburger commented Apr 11, 2019 • edited Loading

stalep commented Apr 11, 2019

vorburger commented Apr 11, 2019

vorburger commented Apr 11, 2019

stalep commented Apr 12, 2019

vorburger commented Apr 12, 2019

geoand commented Apr 12, 2019

vorburger commented Apr 29, 2019

stuartwdouglas May 31, 2019

Choose a reason for hiding this comment

vorburger Jun 10, 2019

Choose a reason for hiding this comment

cescoffier commented Jun 7, 2019

vorburger commented Jun 10, 2019

vorburger commented Jun 10, 2019

emmanuelbernard commented Jun 26, 2019

dmlloyd commented Jul 10, 2019

dmlloyd commented Jul 10, 2019

geoand commented Jul 10, 2019

emmanuelbernard commented Nov 12, 2019

vorburger commented Apr 10, 2019 •

edited

Loading

vorburger commented Apr 11, 2019 •

edited

Loading