-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArC - handle types of removed beans more leniently #24398
Conversation
mkouba
commented
Mar 18, 2022
- log a warning if unable to load a bean type of a removed bean
- previously the app failed at startup
- resolves Removal of beans loads referenced classes #24338
Note that this modification makes the bytecode of the generated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked at the generated ComponentsProvider
class with and without the changes in this PR and I think it looks good!
Ok, let's run the CI then... |
This comment has been minimized.
This comment has been minimized.
- log a warning if unable to load a bean type of a removed bean - previously the app failed at startup - resolves quarkusio#24338
Failing Jobs - Building cf38835
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/grpc-hibernate-reactive
📦 integration-tests/grpc-hibernate-reactive✖
|
The test above has been flaky lately. /cc @DavideD @michalszynkiewicz |
@mkouba I think the problem is that the order between |
This should fix the test failure: #24420 but I'm not able to reproduce it locally (tried 100 times with no failure). |