Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - load removed beans lazily #28112

Merged
merged 1 commit into from
Sep 22, 2022
Merged

ArC - load removed beans lazily #28112

merged 1 commit into from
Sep 22, 2022

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Sep 21, 2022

@mkouba mkouba requested review from Ladicek and manovotn September 21, 2022 05:24
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/rest labels Sep 21, 2022
@mkouba
Copy link
Contributor Author

mkouba commented Sep 21, 2022

I'm investigating the AnnotationServletTestCase failure. It's related to this piece of code.

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
Copy link
Contributor Author

mkouba commented Sep 21, 2022 •
edited
Loading

I'm investigating the AnnotationServletTestCase failure. It's related to this piece of code.

This build step should solve the issue. I've also created #28115 to fix/revisit the non-standard behavior of ArcContainer#instanceSupplier().

I've reverted the change in BeanContainer.instanceFactory() because it would break compatibility in many places :-(

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
Ladicek
Ladicek approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@Ladicek Ladicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I didn't really look at the generated bytecode :-)

manovotn
manovotn approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, LGTM!

@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba
ArC - load removed beans lazily
1b783fe 
- only if Instance#get(), InjectableInstance#getHandle() and ArcContainer.instance() is called
- added InjectableInstance.orElse() and InjectableInstance.orNull()
- resolves quarkusio#18345
@mkouba mkouba added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 22, 2022
@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@mkouba mkouba merged commit abc8ccd into quarkusio:main Sep 22, 2022
@quarkus-bot quarkus-bot bot added this to the 2.14 - main milestone Sep 22, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 22, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Sep 22, 2022
mkouba added a commit to mkouba/quarkus that referenced this pull request Sep 1, 2023
@mkouba
ArC: log warning about removed beans for BeanContainer operations
c1e6248 
- this warning got accidentally removed in
quarkusio#28112 (quarkus 2.14)
@mkouba mkouba mentioned this pull request Sep 1, 2023
Merged
gsmet pushed a commit to gsmet/quarkus that referenced this pull request Sep 4, 2023
@mkouba @gsmet
ArC: log warning about removed beans for BeanContainer operations
6637dda 
- this warning got accidentally removed in
quarkusio#28112 (quarkus 2.14)

(cherry picked from commit c1e6248)
aloubyansky pushed a commit to aloubyansky/quarkus that referenced this pull request Oct 25, 2023
@mkouba @aloubyansky
ArC: log warning about removed beans for BeanContainer operations
4c6b900 
- this warning got accidentally removed in
quarkusio#28112 (quarkus 2.14)

(cherry picked from commit c1e6248)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/rest area/undertow kind/enhancement New feature or request
Projects
None yet
Milestone
2.14.0.CR1
Development

Successfully merging this pull request may close these issues.

Avoid loading the list of ArC removed beans into the heap
3 participants
@mkouba @Ladicek @manovotn