-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove use/mention of 'compile quarkus:dev' #28999
Conversation
/cc @gsmet, @loicmathieu, @yrodiere |
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
We have to be careful about this. Explicit |
...ts/tools/base-codestarts/src/main/resources/codestarts/quarkus/buildtool/maven/codestart.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me but it will require a squash.
I will let @aloubyansky decide if it's the way to go though. My understanding is that we already recommended using mvn quarkus:dev
.
This comment has been minimized.
This comment has been minimized.
@@ -861,7 +861,7 @@ Run the application and notice the `Installed Features` list contains the `greet | |||
|
|||
[source,shell,subs=attributes+] | |||
---- | |||
$ mvn clean compile quarkus:dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kind of minor but the logs below are for mvn clean compile quarkus:dev
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated it - interesting to see how more "noisy" our output become in a year ;)
@@ -2278,7 +2278,7 @@ Otherwise, Quarkus attempts to monitor the extension classes and this may result | |||
|
|||
[source,bash] | |||
---- | |||
./mvnw compile quarkus:dev -DnoDeps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This paragraph is dedicated to multimodule projects and this is where we should mention when explicit compile
is recommended. This paragraph is also outdated. Our bootstrap has evolved since those days and is a lot more reliable today. -DnoDeps
isn't really required today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on mentioning compile
, maybe even test-compile
for continuous testing.
PS: Because of a error when using ECJ, I had to resort to specifying an explicit goal, so that devmojo doesn't run those executions on its own (because this is where the error happens).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aloubyansky I think it would probably be easier if you added an additional commit on top of @maxandersen 's changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aloubyansky I've reworked this section to talk about need for explicit compile and removed noDeps mention. Should it be mentioned somewhere else or is noDeps just not relevant to use anymore ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default we make as many modules in the workspace reloadable as we can handle (exceptions are extension artifacts, dependencies of extensions, parent-first artifacts and dependencies of parent-first).
noDeps
makes only the app root module reloadable.
"don't seem to" as in the behaviour looks differently to users and thus must use |
This comment has been minimized.
This comment has been minimized.
Could we fix the issues and finalize this? @aloubyansky I think you're the best person to get this done quickly. |
@gsmet I think it's ok. It does now mention |
@maxandersen PR needs update, one conflicting file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rebased the PR, it can now be merged once CI is green.
🙈 The PR is closed and the preview is expired. |
compile quarkus:dev
was needed in pre 1.0 Quarkus - time to remove it as not needed.