Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should use -Dno-format to execute other plugins too #29758

Merged
merged 4 commits into from
Dec 9, 2022
Merged

CI should use -Dno-format to execute other plugins too #29758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8747000
CI should use -Dno-format to execute other plugins too
gastaldi Dec 8, 2022
3cb5172
Trigger native build
gastaldi Dec 8, 2022
e97c696
Bump quarkiverse-parent to 12
gastaldi Dec 8, 2022
a74d91a
Fix typo
gastaldi Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../resources/codestarts/quarkus-extension/code/quarkiverse/java/.github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,7 @@ jobs:
cache: 'maven'

- name: Build with Maven
run: mvn -B formatter:validate clean install --file pom.xml
run: mvn -B clean verify -Dno-format

- name: Build with Maven (Native)
run: mvn -B verify -Dnative -Dquarkus.native.container-build -Dnative.surefire.skip
2 changes: 1 addition & 1 deletion ...cts/tools/devtools-common/src/main/java/io/quarkus/devtools/commands/CreateExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public enum LayoutType {

public static final String DEFAULT_QUARKIVERSE_PARENT_GROUP_ID = "io.quarkiverse";
public static final String DEFAULT_QUARKIVERSE_PARENT_ARTIFACT_ID = "quarkiverse-parent";
public static final String DEFAULT_QUARKIVERSE_PARENT_VERSION = "10";
public static final String DEFAULT_QUARKIVERSE_PARENT_VERSION = "12";
public static final String DEFAULT_QUARKIVERSE_NAMESPACE_ID = "quarkus-";
public static final String DEFAULT_QUARKIVERSE_GUIDE_URL = "https://quarkiverse.github.io/quarkiverse-docs/%s/dev/";

Expand Down
4 changes: 2 additions & 2 deletions ...cts/tools/devtools-testing/src/main/java/io/quarkus/devtools/testing/SnapshotTesting.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public static AbstractPathAssert<?> assertThatMatchSnapshot(Path fileToCheck, St

final String snapshotNotFoundDescription = "corresponding snapshot file not found for " + snapshotIdentifier
+ " (Use -Dsnap to create it automatically)";
final String description = "Snapshot is not matching (use -Dsnap to udpate it automatically): "
final String description = "Snapshot is not matching (use -Dsnap to update it automatically): "
+ snapshotIdentifier;
if (isUTF8File(fileToCheck)) {
assertThat(snapshotFile).as(snapshotNotFoundDescription).isRegularFile();
Expand Down Expand Up @@ -264,7 +264,7 @@ public static ListAssert<String> assertThatDirectoryTreeMatchSnapshots(String sn
.collect(toList());

return assertThat(tree)
.as("Snapshot is not matching (use -Dsnap to udpate it automatically):" + snapshotName)
.as("Snapshot is not matching (use -Dsnap to update it automatically):" + snapshotName)
.containsExactlyInAnyOrderElementsOf(content);
});
}
Expand Down
2 changes: 1 addition & 1 deletion ..._/CreateExtensionMojoIT/testCreateQuarkiverseExtension/quarkus-my-quarkiverse-ext_pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<parent>
<groupId>io.quarkiverse</groupId>
<artifactId>quarkiverse-parent</artifactId>
<version>10</version>
<version>12</version>
</parent>
<groupId>io.quarkiverse.my-quarkiverse-ext</groupId>
<artifactId>quarkus-my-quarkiverse-ext-parent</artifactId>
Expand Down