Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide proper error message for missing URL with Keycloak Admin client bean #29772

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Provide proper error message for missing URL with Keycloak Admin client bean #29772

merged 1 commit into from
Dec 9, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Dec 9, 2022 •
edited
Loading

I ran into this when looking at #29712. Without this change, users are presented with a totally misleading ContextNotActiveException

Edit

Fixes: #29958

@geoand geoand requested a review from sberyozkin December 9, 2022 09:53
gsmet
gsmet requested changes Dec 9, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Very minor but let's get Keycloak's case right.

...rkus/keycloak/admin/client/reactive/runtime/ResteasyReactiveKeycloakAdminClientRecorder.java Outdated Show resolved Hide resolved
...ntime/src/main/java/io/quarkus/keycloak/adminclient/ResteasyKeycloakAdminClientRecorder.java Outdated Show resolved Hide resolved
@geoand @gsmet
Provide proper error message for missing URL with Keycloak Admin clie…
eb7f003 
…nt bean

Co-authored-by: Guillaume Smet <guillaume.smet@gmail.com>
@geoand geoand force-pushed the keycloak-admin-cdi branch from a852ecc to eb7f003 Compare December 9, 2022 10:05
@geoand
Copy link
Contributor Author

geoand commented Dec 9, 2022

Good catch! Fixed :)

@geoand geoand mentioned this pull request Dec 9, 2022
Closed
@geoand
Copy link
Contributor Author

geoand commented Dec 9, 2022

#29773 is also related

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 9, 2022

Failing Jobs - Building eb7f003

Status Name Step Failures Logs Raw logs
✔️ JVM Tests - JDK 11
✔️ JVM Tests - JDK 17
✖ JVM Tests - JDK 17 MacOS M1 Set up runner ⚠️ Check → Logs Raw logs
✔️ JVM Tests - JDK 18

gsmet
gsmet approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me but probably better to let @sberyozkin have the final say.

sberyozkin
sberyozkin approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@sberyozkin sberyozkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @geoand

@sberyozkin sberyozkin merged commit 24aeefd into quarkusio:main Dec 9, 2022
@quarkus-bot quarkus-bot bot added this to the 2.16 - main milestone Dec 9, 2022
@sberyozkin
Copy link
Member

Thanks @gsmet for the review 👍

@geoand
Copy link
Contributor Author

geoand commented Dec 9, 2022

🙏🏼

@geoand geoand deleted the keycloak-admin-cdi branch December 9, 2022 10:50
@geoand geoand mentioned this pull request Dec 20, 2022
Closed
@gsmet gsmet modified the milestones: 2.16 - main, 2.15.1.Final Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sberyozkin sberyozkin sberyozkin approved these changes

@gsmet gsmet gsmet approved these changes

Assignees
No one assigned
Labels
area/keycloak
Projects
None yet
Milestone
2.15.1.Final
Development

Successfully merging this pull request may close these issues.

Issue using keycloak admin client
3 participants
@geoand @sberyozkin @gsmet