Upgrade to maven-compiler-plugin 3.11.0

[gsmet]

No description provided.

[github-actions]

🙈 The PR is closed and the preview is expired.

[gsmet]

@aloubyansky interested in your opinion on this: we were still using Maven Compiler Plugin 3.8.1 to compile Quarkus.

[aloubyansky]

Sounds like a good idea

[gsmet]

@geoand did you end up moving to Windows in the end? From what I could understand, I think the error is due to some invalid character in the report but the error message is very cryptic and I have no idea where it could come from.

It might be a regression in a Maven plugin but it's hard to know.

2023-03-07T22:57:03.5409484Z     at org.apache.maven.wrapper.MavenWrapperMain.main (MavenWrapperMain.java:76)
2023-03-07T22:57:03.5409759Z Caused by: java.nio.charset.UnmappableCharacterException: Input length = 1
2023-03-07T22:57:03.5410025Z     at java.nio.charset.CoderResult.throwException (CoderResult.java:275)
2023-03-07T22:57:03.5410259Z     at sun.nio.cs.StreamEncoder.implWrite (StreamEncoder.java:307)
2023-03-07T22:57:03.5411185Z     at sun.nio.cs.StreamEncoder.implWrite (StreamEncoder.java:282)
2023-03-07T22:57:03.5411499Z     at sun.nio.cs.StreamEncoder.write (StreamEncoder.java:132)
2023-03-07T22:57:03.5411736Z     at java.io.OutputStreamWriter.write (OutputStreamWriter.java:205)
2023-03-07T22:57:03.5411966Z     at java.io.BufferedWriter.flushBuffer (BufferedWriter.java:120)
2023-03-07T22:57:03.5412177Z     at java.io.BufferedWriter.write (BufferedWriter.java:233)
2023-03-07T22:57:03.5412345Z     at java.io.Writer.write (Writer.java:249)
2023-03-07T22:57:03.5412633Z     at org.apache.maven.shared.utils.io.FileUtils.fileWriteArray (FileUtils.java:460)
2023-03-07T22:57:03.5412918Z     at org.apache.maven.shared.utils.io.FileUtils.fileWriteArray (FileUtils.java:437)
2023-03-07T22:57:03.5413322Z     at org.apache.maven.plugin.compiler.AbstractCompilerMojo.computeInputFileTreeChanges (AbstractCompilerMojo.java:1704)
2023-03-07T22:57:03.5414023Z     at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute (AbstractCompilerMojo.java:858)
2023-03-07T22:57:03.5414359Z     at org.apache.maven.plugin.compiler.TestCompilerMojo.execute (TestCompilerMojo.java:199)

From what I can see, the failure is here: https://github.com/apache/maven-compiler-plugin/blob/master/src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java#L1704 .

Do we have a file in the tree with a special character?

[geoand]

@geoand did you end up moving to Windows in the end

Nope, not yet

[geoand]

Maybe @Karm who recently built on a new Windows installation can help

[jorsol]

@gsmet This is the issue:

/quarkus/extensions/resteasy-reactive/quarkus-resteasy-reactive/deployment/src/test/java/io/quarkus/resteasy/reactive/server/test/customexceptions/InvalidConditionalΜappersTest.java

The filename of this class uses a unicode character that can't be mapped on Windows using the default encoding. While this should not be a big deal, and it might be a small issue from maven-compiler-plugin (probably it should be using UTF-8 by default [or not]), IMO the file names should use ASCII chars.

[gsmet]

@jorsol oh, good catch! Will fix that and see how it goes!

[jorsol]

Remember to not only rename the file name, but also the class name.

[gsmet]

@jorsol yeah, I actually did the mistake but fixed it right away. Things should be all good now.

[quarkus-bot]

Failing Jobs - Building e5d0078

Status	Name	Step	Failures	Logs	Raw logs
✔️	Gradle Tests - JDK 11
⌛	Gradle Tests - JDK 11 Windows	Build	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 11
✔️	JVM Tests - JDK 17
✖	JVM Tests - JDK 17 Windows	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 19

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/resteasy-classic/rest-client/runtime 
! Skipped: extensions/amazon-lambda-http/deployment extensions/amazon-lambda-http/http-event-server extensions/amazon-lambda-rest/deployment and 104 more

📦 extensions/resteasy-classic/rest-client/runtime

✖ io.quarkus.restclient.runtime.RestClientBaseTest. - More details - Source on GitHub

java.io.IOException: Failed to delete temp directory D:\a\quarkus\quarkus\extensions\resteasy-classic\rest-client\runtime\target\junit11742687702876333230. The following paths could not be deleted (see suppressed exceptions for details): 
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:350)
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:251)