Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace wildcard imports with specific imports for better code maintainability #31823

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Replace wildcard imports with specific imports for better code maintainability #31823

merged 1 commit into from
Mar 14, 2023

Conversation

karaelf33
Copy link
Contributor

@karaelf33 karaelf33 commented Mar 13, 2023 •
edited
Loading

In the project's codebase, there are many instances of wildcard imports being used to import all names from a module or package. This can lead to naming collisions and make it harder to understand where certain variables and functions are coming from.

Fixes #31789

@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/infinispan Infinispan area/mongodb area/persistence OBSOLETE, DO NOT USE labels Mar 13, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 13, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

Sanne
Sanne approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@Sanne Sanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Sanne Sanne added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 13, 2023
@karaelf33
Copy link
Contributor Author

Thanks!

Thanks for the review, Sanne

@quarkus-bot

This comment has been minimized.

Sign in to view
@karaelf33
Copy link
Contributor Author

Job got an error because of this ->"check (check-imports) on project ...: Imports are not sorted in .."
I changed the order of imports according to the alphabet, push a more commit and squashed both

@quarkus-bot

This comment has been minimized.

Sign in to view
@karaelf33 karaelf33 force-pushed the main branch 2 times, most recently from 67df9fd to f486cf4 Compare March 13, 2023 21:28
@Sanne
Copy link
Member

Sanne commented Mar 13, 2023

Please check https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style

In particular this might be useful:

If you want to run the formatting without doing a full build, you can run ./mvnw process-sources

@quarkus-bot

This comment has been minimized.

Sign in to view
@Sanne
Copy link
Member

Sanne commented Mar 13, 2023

Could you please ensure formatting is working fine before sending more updates, we can't have CI work just for you :)

@gsmet
Copy link
Member

gsmet commented Mar 14, 2023

I force pushed the formatting fixes, please don't touch this PR anymore, it should be good to go, now. Thanks.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 14, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 50c7638 into quarkusio:main Mar 14, 2023
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 14, 2023
@gsmet
Copy link
Member

gsmet commented Mar 14, 2023

Thanks.

@quarkus-bot quarkus-bot bot added this to the 3.0 - main milestone Mar 14, 2023
@karaelf33
Copy link
Contributor Author

karaelf33 commented Mar 14, 2023 •
edited
Loading

Please check https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style

In particular this might be useful:

If you want to run the formatting without doing a full build, you can run ./mvnw process-sources

Thanks Sanne, I am going to check more carefully.

@karaelf33
Copy link
Contributor Author

Could you please ensure formatting is working fine before sending more updates, we can't have CI work just for you :)

I will be more careful next time. I appreciate advice.

@karaelf33
Copy link
Contributor Author

I force pushed the formatting fixes, please don't touch this PR anymore, it should be good to go, now. Thanks.

I appreciate a hand, Gsmet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/infinispan Infinispan area/mongodb area/persistence OBSOLETE, DO NOT USE kind/bugfix
Projects
None yet
Milestone
3.0.0.Alpha6
Development

Successfully merging this pull request may close these issues.

Replace wildcard imports with specific imports for better code maintainability
3 participants
@karaelf33 @Sanne @gsmet