Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(2.16) Upgrade to graphql-java 19.4 #32253

Merged
merged 1 commit into from
Apr 2, 2023
Merged

(2.16) Upgrade to graphql-java 19.4 #32253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion bom/application/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<micrometer.version>1.10.2</micrometer.version><!-- keep in sync with hdrhistogram -->
<hdrhistogram.version>2.1.12</hdrhistogram.version><!-- keep in sync with micrometer -->
<google-auth.version>0.22.0</google-auth.version>
<graphql-java.version>19.4</graphql-java.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. I'm not sure it's a good idea to do that. Didn't you release a SmallRye GraphQL version with the updated dependency?
If we have to do that, please make sure the version is put just below smallrye-graphql.version with a comment saying they need to be kept in sync. But I would rather avoid it if we can.

<microprofile-config-api.version>2.0.1</microprofile-config-api.version>
<microprofile-metrics-api.version>3.0.1</microprofile-metrics-api.version>
<microprofile-context-propagation.version>1.2</microprofile-context-propagation.version>
Expand All @@ -47,7 +48,7 @@
<smallrye-health.version>3.3.1</smallrye-health.version>
<smallrye-metrics.version>3.0.5</smallrye-metrics.version>
<smallrye-open-api.version>3.1.1</smallrye-open-api.version>
<smallrye-graphql.version>1.9.4</smallrye-graphql.version>
<smallrye-graphql.version>1.9.5</smallrye-graphql.version>
<smallrye-opentracing.version>2.1.1</smallrye-opentracing.version>
<smallrye-fault-tolerance.version>5.6.0</smallrye-fault-tolerance.version>
<smallrye-jwt.version>3.6.0</smallrye-jwt.version>
Expand Down Expand Up @@ -5936,6 +5937,13 @@
<version>${hdrhistogram.version}</version>
</dependency>

<!-- GraphQL-java -->
<dependency>
<groupId>com.graphql-java</groupId>
<artifactId>graphql-java</artifactId>
<version>${graphql-java.version}</version>
</dependency>

<!-- Quarkus build related dependencies -->
<dependency>
<groupId>org.apache.commons</groupId>
Expand Down