Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undertow warning instead of error if not found #32793

Closed
wants to merge 1 commit into from

Conversation

melloware
Copy link
Contributor

@melloware melloware commented Apr 20, 2023

@stuartwdouglas just for safety I think we should change this to a warning because now I am getting 'jakarta.faces` directory does not exist.

Fix #32724

@melloware
Copy link
Contributor Author

cc @aloubyansky

@quarkus-bot

This comment has been minimized.

@stuartwdouglas
Copy link
Member

Do you have a reproducer for the other issue? I am ok with this being a warning, but would like to understand the root cause.

@melloware
Copy link
Contributor Author

melloware commented Apr 21, 2023

Yes my reproducer is the PrimeFaces Extension integration tests they are failing with the nightly 999-SNAPSHOT in Native Mode. See: https://github.com/quarkiverse/quarkus-primefaces/actions/runs/4761639897/jobs/8463084098

Unable to get listed resource jakarta.faces from directory for path from underlying manager io.undertow.server.handlers.resource.ClassPathResourceManager@79802a5dError

@melloware melloware force-pushed the 32724-2 branch 2 times, most recently from 747bc56 to 3fb0e9e Compare April 21, 2023 16:40
@melloware
Copy link
Contributor Author

Also OmniFaces Extension failing for the same reason: https://github.com/quarkiverse/quarkus-omnifaces/actions/runs/4761634843

@melloware melloware force-pushed the 32724-2 branch 4 times, most recently from 94728b6 to 85bc959 Compare April 24, 2023 14:14
@melloware
Copy link
Contributor Author

@stuartwdouglas @aloubyansky when I run in JVM mode the Integration test passes and here is what gets printed out by the KnownPaths class

Resource: error.xhtml
Resource: favicon.ico
Resource: index.xhtml
Resource: notfound.xhtml
Resource: jakarta.faces
Resource: layout
Resource: omnifaces
Resource: org.apache.myfaces.windowId

But when running in Native mode it fails fast on Resource: jakarta.faces I don't know why.

@melloware
Copy link
Contributor Author

I would really like to get this merged until we can figure out the real issue as this breaks all JSF related apps using OmniFaces , MyFaces, or PrimeFaces.

@gastaldi
Copy link
Contributor

Can you squash your commits before we merge this?

Undertow warning instead of error if not found
@melloware
Copy link
Contributor Author

Squashed!

@quarkus-bot
Copy link

quarkus-bot bot commented Apr 25, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@stuartwdouglas
Copy link
Member

My guess is that things that are added as known paths in may not be added to the actual native executable, or alternatively it could be that directories are handled differently in native mode and are not showing up.

@stuartwdouglas
Copy link
Member

Any chance you could test out #32893 ?

@melloware
Copy link
Contributor Author

@stuartwdouglas @gastaldi so weird so 3.0.1 just came out and OmniFaces and PrimeFaces builds are passing with it but still failing with the 999-SNAPSHOT overnight build?

@gastaldi
Copy link
Contributor

Try emptying your ~/.m2/repository/io/quarkus and building 999-SNAPSHOT again just in case?

@melloware
Copy link
Contributor Author

@gastaldi sorry I meant on GitHub Actions. 6 hours ago the EcoSystem CI failed with 999-SNAPSHOT but I just built with 3.0.1 from Dependabot and all tests are passing.

See this: https://github.com/quarkiverse/quarkus-omnifaces/actions

That makes NO sense unless something with the GitHub Actions Maven Cache is messed up on the servers. Like its using an old 999-SNAPSHOT?

@gastaldi
Copy link
Contributor

And can you reproduce the failure building it locally?

@melloware
Copy link
Contributor Author

Let me try and get set up I use Windows so its not apples to apples with GitHub Actions which was my concern when the overnight EcoSystem CI was failing on Linux.

@melloware
Copy link
Contributor Author

OK @stuartwdouglas something weird is going on here. If I run the code I posted in the original ticket it doesn't work with 3.0.1.Final.

#28028

quarkus-servlet.zip

  1. Unzip the reproducer attached
  2. Run mvn clean quarkus:dev and see the servlet paths printed out 2022-12-27 13:00:20,489 INFO [org.acm.ApplicationInitializer] (Quarkus Main Thread) Resource: /index.html
  3. Run mvn clean package -DskipTests && java -jar target/quarkus-app/quarkus-run.jar and see the WARNING that no paths found 2022-12-27 13:01:06,297 WARNING [org.acm.ApplicationInitializer] (main) NO servlet resource paths found!

So even in JVM production mode its not finding the /index.html again?

@melloware
Copy link
Contributor Author

OHHH is it possible none of this code is in 3.0.1 which would explain it and why the nightly build is actually failing.

@melloware
Copy link
Contributor Author

More info and test case: #33018

@gsmet
Copy link
Member

gsmet commented May 2, 2023

Closing this one in favor of #32893 .

@gsmet gsmet closed this May 2, 2023
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport? labels May 2, 2023
@melloware melloware deleted the 32724-2 branch May 2, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/undertow triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undertow: Servlet context path failing with _static directory
4 participants