-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undertow warning instead of error if not found #32793
Conversation
cc @aloubyansky |
This comment has been minimized.
This comment has been minimized.
Do you have a reproducer for the other issue? I am ok with this being a warning, but would like to understand the root cause. |
Yes my reproducer is the PrimeFaces Extension integration tests they are failing with the nightly 999-SNAPSHOT in Native Mode. See: https://github.com/quarkiverse/quarkus-primefaces/actions/runs/4761639897/jobs/8463084098
|
747bc56
to
3fb0e9e
Compare
Also OmniFaces Extension failing for the same reason: https://github.com/quarkiverse/quarkus-omnifaces/actions/runs/4761634843 |
94728b6
to
85bc959
Compare
@stuartwdouglas @aloubyansky when I run in JVM mode the Integration test passes and here is what gets printed out by the KnownPaths class
But when running in Native mode it fails fast on |
...ons/undertow/runtime/src/main/java/io/quarkus/undertow/runtime/KnownPathResourceManager.java
Outdated
Show resolved
Hide resolved
I would really like to get this merged until we can figure out the real issue as this breaks all JSF related apps using OmniFaces , MyFaces, or PrimeFaces. |
Can you squash your commits before we merge this? |
Undertow warning instead of error if not found
Squashed! |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
My guess is that things that are added as known paths in may not be added to the actual native executable, or alternatively it could be that directories are handled differently in native mode and are not showing up. |
Any chance you could test out #32893 ? |
@stuartwdouglas @gastaldi so weird so 3.0.1 just came out and OmniFaces and PrimeFaces builds are passing with it but still failing with the 999-SNAPSHOT overnight build? |
Try emptying your ~/.m2/repository/io/quarkus and building 999-SNAPSHOT again just in case? |
@gastaldi sorry I meant on GitHub Actions. 6 hours ago the EcoSystem CI failed with 999-SNAPSHOT but I just built with 3.0.1 from Dependabot and all tests are passing. See this: https://github.com/quarkiverse/quarkus-omnifaces/actions That makes NO sense unless something with the GitHub Actions Maven Cache is messed up on the servers. Like its using an old 999-SNAPSHOT? |
And can you reproduce the failure building it locally? |
Let me try and get set up I use Windows so its not apples to apples with GitHub Actions which was my concern when the overnight EcoSystem CI was failing on Linux. |
OK @stuartwdouglas something weird is going on here. If I run the code I posted in the original ticket it doesn't work with 3.0.1.Final.
So even in JVM production mode its not finding the /index.html again? |
OHHH is it possible none of this code is in 3.0.1 which would explain it and why the nightly build is actually failing. |
More info and test case: #33018 |
Closing this one in favor of #32893 . |
@stuartwdouglas just for safety I think we should change this to a warning because now I am getting 'jakarta.faces` directory does not exist.
Fix #32724