Provide a way to push env variables to dev services containers

[gsmet]

Fixes #33864

@Eng-Fouad could you give it a try? Thanks!

[quarkus-bot]

/cc @loicmathieu (elasticsearch), @yrodiere (elasticsearch)

[Eng-Fouad]

Tried this configuration:

quarkus.datasource.devservices.container-env.MSSQL_COLLATION=Arabic_100_CS_AS_KS_WS_SC_UTF8

and it worked perfectly. Thanks.

---

Logs from mssql container:

Attempting to change default collation to Arabic_100_CS_AS_KS_WS_SC_UTF8.
The default collation was successfully changed.

[Eng-Fouad]

I got this error, whenever I use container-env:

Login failed for user 'SA'. Reason: Could not find a login matching the name provided

May be the default environment variables are overridden.

---

EDIT:

It seems unrelated issue. I changed the collation to SQL_Latin1_General_CP1_CI_AS, and it worked perfectly.

I even set this config:

quarkus.datasource.devservices.container-env.ACCEPT_EULA=Y

and I didn't need for container-license-acceptance.txt to be existed.

[yrodiere]

@gsmet We probably need to merge user-provided environment variables with the ones we set ourselves (e.g. username)?

[Eng-Fouad]

@gsmet We probably need to merge user-provided environment variables with the ones we set ourselves (e.g. username)?

I think there is no need to do that, as we are already using withEnv which appends to the existing environment variables:

public SELF withEnv(Map<String, String> env) {
    env.forEach(this::addEnv);
    return self();
}

public void addEnv(String key, String value) {
    env.put(key, value);
}

https://github.com/testcontainers/testcontainers-java/blob/7112db5c6e493306360818d6bfc261df92c49255/core/src/main/java/org/testcontainers/containers/GenericContainer.java#L1207

[gsmet]

@Eng-Fouad I wonder if the collation is not causing issues with matching the user name. Could you try to connect from the command line with SA and then with sa and see if it makes a difference?

[Eng-Fouad]

@Eng-Fouad I wonder if the collation is not causing issues with matching the user name. Could you try to connect from the command line with SA and then with sa and see if it makes a difference?

Indeed, that was the problem.

I had this config:

%dev.quarkus.datasource.username=SA

changing it to sa resolved the issue.

[gsmet]

I think the default from Testcontainers is also SA so we probably want to lowercase it.

[Eng-Fouad]

Submitted a bug report to testcontainers-java: testcontainers/testcontainers-java#7237

[gsmet]

@Eng-Fouad could you retest with my latest changes and removing %dev.quarkus.datasource.username entirely? I think it should work out of the box now.

[quarkus-bot]

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

[Eng-Fouad]

@Eng-Fouad could you retest with my latest changes and removing %dev.quarkus.datasource.username entirely? I think it should work out of the box now.

Yes. It works.