Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plugin config to global parent and clean up other parents #35607

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Move plugin config to global parent and clean up other parents #35607

merged 1 commit into from
Sep 12, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Aug 28, 2023

@gastaldi @aloubyansky could you have a closer look at this to make sure I didn't break anything?

@gsmet gsmet requested review from gastaldi and aloubyansky August 28, 2023 18:46
@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform area/spring Issues relating to the Spring integration labels Aug 28, 2023
@gsmet
Copy link
Member Author

gsmet commented Aug 28, 2023

Note that I did this because I mistakenly changed the configuration of the Nexus plugin on the root pom while I should have done it in the parent pom.
The fact that we have release profiles all over the place was very confusing and can be cleaned up now that we have a common parent.

gastaldi
gastaldi approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, LGTM

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot
Copy link

quarkus-bot bot commented Sep 7, 2023

Failing Jobs - Building 75dd814

Status Name Step Failures Logs Raw logs Build scan
✖ Maven Tests - JDK 11 Build Failures Logs Raw logs
✔️ Maven Tests - JDK 11 Windows

Full information is available in the Build summary check run.

Failures

⚙️ Maven Tests - JDK 11 #

- Failing: integration-tests/devmode

📦 integration-tests/devmode

✖ io.quarkus.test.devui.DevUIHibernateOrmSmokeTest.testGetNumberOfNamedQueries - More details - Source on GitHub

io.quarkus.dev.appstate.ApplicationStartException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.dev.appstate.ApplicationStateNotification.waitForApplicationStart(ApplicationStateNotification.java:58)
	at io.quarkus.runner.bootstrap.StartupActionImpl.runMainClass(StartupActionImpl.java:132)

@gsmet gsmet merged commit 718a8d5 into quarkusio:main Sep 12, 2023
@quarkus-bot quarkus-bot bot added this to the 3.5 - main milestone Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloubyansky aloubyansky aloubyansky approved these changes

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle area/platform Issues related to definition and interaction with Quarkus Platform area/spring Issues relating to the Spring integration
Projects
None yet
Milestone
3.5.0.CR1
Development

Successfully merging this pull request may close these issues.
3 participants
@gsmet @gastaldi @aloubyansky