Use java.util.Locale to parse the languages from the Accept-Language header

[nderwin]

• Fixes: Accept-Language header not parsed correctly for language subtags, variants, extension and private subtags #36227.

[geoand]

Thanks for this!

Would you like to add some new tests that verify the behavior?

[nderwin]

@geoand Sure, where would they go, in the integration-tests module? Hrm, I don't see an existing resteasy-reactive module there (not counting the Kotlin one).

[geoand]

I would add one here

[geoand]

I have launched CI, let's see what it says

[nderwin]

🤞

[gsmet]

This looks good, thanks.

I will let @geoand approve and merge when he's back from Devoxx.

[geoand]

Thanks. I want to have a closer looks because either the Javadoc of the method is outdated, or something more subtle is going on.

[nderwin]

@geoand Also keep an eye on resteasy/resteasy#3808 - I made the same change for the non-reactive RESTEasy, and it tripped on the Jakarta REST TCK. If it's rejected there, then we should probably reject this too, for consistency.

[geoand]

Thanks for the heads up @nderwin.

Let's convert this into a draft as well.

[nderwin]

My PR for RESTEasy was replaced with these two that were merged:

resteasy/resteasy#4054
resteasy/resteasy#4055

[gsmet]

Thanks for the follow-up. How did the TCK issue get fixed?

[nderwin]

I'm not sure. I wasn't really clear on what the TCK issue was, unfortunately.

[nderwin]

I think it's been long enough that we can turn this back into a real PR.

[geoand]

Thanks!

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 633a16c.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

---

Flaky tests - Develocity

⚙️ JVM Tests - JDK 17

📦 extensions/infinispan-cache/deployment

✖ io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls - History

• expected: "thread1" but was: "thread2" - org.opentest4j.AssertionFailedError

org.opentest4j.AssertionFailedError: 

expected: "thread1"
 but was: "thread2"
	at io.quarkus.cache.infinispan.InfinispanCacheTest.testGetAsyncWithParallelCalls(InfinispanCacheTest.java:283)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:513)
	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:427)

[geoand]

As this is doing the same as RESTEasy is now doing, it makes perfect sense to merge it.

Thanks a lot for the contribution!