Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Live Coding support for Kafka Streams #3679

Merged

Conversation

gunnarmorling
Copy link
Contributor

No description provided.

@gunnarmorling
Copy link
Contributor Author

@gsmet, @cescoffier, could either of you review this one? Thanks!

Copy link
Member

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Waiting for @stuartwdouglas feedback.

@stuartwdouglas
Copy link
Member

This looks good to me. Any chance you could add a test using QuarkusDevModeTest?

@cescoffier
Copy link
Member

@gunnarmorling can you look into implementing a QuarkusDevModeTest?

@gunnarmorling
Copy link
Contributor Author

gunnarmorling commented Aug 27, 2019 via email

@stuartwdouglas stuartwdouglas merged commit 4703d0e into quarkusio:master Aug 27, 2019
@stuartwdouglas
Copy link
Member

Ok, we can add the test later.

@gsmet
Copy link
Member

gsmet commented Aug 27, 2019

FYI, if we have a release this week, it will be a pure bugfix release.

This will be in the next one.

@gunnarmorling
Copy link
Contributor Author

gunnarmorling commented Aug 27, 2019 via email

@stuartwdouglas
Copy link
Member

This happens very first thing, so the hot-reload basically happens before it has hit any application logic. When the app is restarted the request continues but into the new application rather than the old one.

@gsmet
Copy link
Member

gsmet commented Aug 28, 2019

@gunnarmorling FYI, change of plan: we will release master tomorrow. So if you want to update the doc, you have until tomorrow morning.

@gunnarmorling
Copy link
Contributor Author

gunnarmorling commented Aug 28, 2019 via email

@gunnarmorling
Copy link
Contributor Author

gunnarmorling commented Aug 28, 2019 via email

@gsmet gsmet added this to the 0.22.0 milestone Aug 28, 2019
@gsmet gsmet changed the title #3500 Dev Mode live reload support for Kafka Streams Add Dev Mode live reload support for Kafka Streams Aug 29, 2019
@gsmet gsmet changed the title Add Dev Mode live reload support for Kafka Streams Add Live Coding support for Kafka Streams Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants