-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Live Coding support for Kafka Streams #3679
Add Live Coding support for Kafka Streams #3679
Conversation
d03d63d
to
c3f0671
Compare
c3f0671
to
e7ce0cc
Compare
@gsmet, @cescoffier, could either of you review this one? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Waiting for @stuartwdouglas feedback.
This looks good to me. Any chance you could add a test using QuarkusDevModeTest? |
@gunnarmorling can you look into implementing a QuarkusDevModeTest? |
Yes, I can look into it, but I'm at a F2F this week, so might take a bit.
If there's a release this week, could we get it in then also without that
test and I'll add it later? Would be nice to have it merged.
… |
Ok, we can add the test later. |
FYI, if we have a release this week, it will be a pure bugfix release. This will be in the next one. |
Stuart, one question btw. on the dev mode for Undertow: how does it work
that you don't "lose" the current HTTP request that's re-triggering the
reload?
… |
This happens very first thing, so the hot-reload basically happens before it has hit any application logic. When the app is restarted the request continues but into the new application rather than the old one. |
@gunnarmorling FYI, change of plan: we will release master tomorrow. So if you want to update the doc, you have until tomorrow morning. |
Thanks for the heads-up. Still in the F2F, but I'll see what I can do; in
general, the live reload will work with default settings, but it requires
some option tuning on the client and broker to make it instant and give the
true snappy feedback feeling, as otherwise there'll be some default delay
for reconnecting to the broker.
… |
No description provided.