-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dynamically resolved Java version when creating Gradle projects #37051
Conversation
Also add tests for Java 21. Fixes quarkusio#37047
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For now, I don't think we have Java 21 images unfortunately but @cescoffier should know more. |
That's why I suggested not to allow Java 21 yet |
Maybe we could find a solution and put a warning on something in the dockerfiles? |
We are waiting for the image. I heard that should be ready in November. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
@ia3andy feel free to do something about it but we would have to revert very soon. We have allowed 21 in Maven for a while and we haven't heard any complaints (yet...). I agree the situation is not perfect but people are eager to use 21 and forbidding them to do it looks like a bad bet to me - even if some pieces are unfortunately missing. I will merge this one, feel free to follow up. |
Also add tests for Java 21.
Fixes #37047