-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Amazon DynamoDB guide #3706
Conversation
Should this be in the same PR as #3172? It seems like this PR is based on that one so I am assuming it should not be merged prior to that one. If that is true, why not make it a single PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcinczeczko I added a bunch of suggestions. Can you have a look?
If `quarkus.dynamodb.credentials.type=PROCESS` used, credentials to be loaded from an external process. This is used to support the credential_process setting in the profile credentials file. | ||
See https://docs.aws.amazon.com/cli/latest/topic/config-vars.html#sourcing-credentials-from-external-processes[Sourcing Credentials From External Processes] for more information. | ||
|
||
It can be configured with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't read everything here. We are working on auto-generating this part from the Javadoc. I don't know how it will fly with this extension as the config is a bit complicated. We'll see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good news. So maybe i'll move some of descriptions to the config beans (as here are a little bit more explanations) and remove it from guide. what do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it that way for now, we are still making progress on this and I think we will need to test and adjust for this particular doc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
cdb6f47
to
3de8f12
Compare
3de8f12
to
c8d6038
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, waiting for the other PR to complete.
Guide for #3172