Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Amazon DynamoDB guide #3706

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Conversation

marcinczeczko
Copy link
Contributor

Guide for #3172

@geoand
Copy link
Contributor

geoand commented Aug 26, 2019

Should this be in the same PR as #3172? It seems like this PR is based on that one so I am assuming it should not be merged prior to that one. If that is true, why not make it a single PR?

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcinczeczko I added a bunch of suggestions. Can you have a look?

docs/src/main/asciidoc/dynamodb-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/dynamodb-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/dynamodb-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/dynamodb-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/dynamodb-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/dynamodb-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/dynamodb-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/dynamodb-guide.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/dynamodb-guide.adoc Outdated Show resolved Hide resolved
If `quarkus.dynamodb.credentials.type=PROCESS` used, credentials to be loaded from an external process. This is used to support the credential_process setting in the profile credentials file.
See https://docs.aws.amazon.com/cli/latest/topic/config-vars.html#sourcing-credentials-from-external-processes[Sourcing Credentials From External Processes] for more information.

It can be configured with:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't read everything here. We are working on auto-generating this part from the Javadoc. I don't know how it will fly with this extension as the config is a bit complicated. We'll see.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's good news. So maybe i'll move some of descriptions to the config beans (as here are a little bit more explanations) and remove it from guide. what do you think ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it that way for now, we are still making progress on this and I think we will need to test and adjust for this particular doc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@marcinczeczko marcinczeczko force-pushed the dynamodb-guide branch 3 times, most recently from cdb6f47 to 3de8f12 Compare August 28, 2019 09:44
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, waiting for the other PR to complete.

@gsmet gsmet changed the title Dynamodb guide Add an Amazon DynamoDB guide Aug 28, 2019
@gsmet gsmet added this to the 0.22.0 milestone Aug 28, 2019
@gsmet gsmet merged commit 91fc2f7 into quarkusio:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants