-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.2] Split Java 17 MongoDB and Hibernate ORM Panache tests #37450
Conversation
The Hibernate ORM is setting up CI for 3.2 to prevent regressions and starting the old MongoDB we have in 3.2 in a recent Fedora is a major pain. Splitting the modules to avoid cross dependencies will help with that. In 3.7+, I will move these tests to their respective modules.
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
Change look good to me, but I have one question: Shouldn't we make the same change also to main? There might not be an immediate need for that, but I'd rather to keep things in sync. |
@rsvoboda you should read what I write :).
Given 3.7+ will be Java 17, we don't need separate modules. |
We have seen several failures lately, let's hope this fixes it.
Failing Jobs - Building 042d460
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/resteasy-reactive/rest-client-reactive/runtime
! Skipped: extensions/keycloak-admin-client-reactive/deployment extensions/keycloak-admin-client-reactive/runtime extensions/oidc-client-reactive-filter/deployment and 30 more 📦 extensions/resteasy-reactive/rest-client-reactive/runtime✖
|
The Hibernate ORM is setting up CI for 3.2 to prevent regressions and starting the old MongoDB we have in 3.2 in a recent Fedora is a major pain.
Splitting the modules to avoid cross dependencies will help with that.
In 3.7+, I will move these tests to their respective modules.
@rsvoboda could you have a look at this one? It won't change a thing for us and would make @beikov 's life easier.