Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Split Java 17 MongoDB and Hibernate ORM Panache tests #37450

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Dec 1, 2023

The Hibernate ORM is setting up CI for 3.2 to prevent regressions and starting the old MongoDB we have in 3.2 in a recent Fedora is a major pain.
Splitting the modules to avoid cross dependencies will help with that.

In 3.7+, I will move these tests to their respective modules.

@rsvoboda could you have a look at this one? It won't change a thing for us and would make @beikov 's life easier.

The Hibernate ORM is setting up CI for 3.2 to prevent regressions and
starting the old MongoDB we have in 3.2 in a recent Fedora is a major
pain.
Splitting the modules to avoid cross dependencies will help with that.

In 3.7+, I will move these tests to their respective modules.
Copy link

quarkus-bot bot commented Dec 1, 2023

/cc @Sanne (hibernate-orm), @yrodiere (hibernate-orm)

Copy link

quarkus-bot bot commented Dec 1, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@rsvoboda rsvoboda self-requested a review December 1, 2023 12:34
@rsvoboda
Copy link
Member

rsvoboda commented Dec 1, 2023

Change look good to me, but I have one question: Shouldn't we make the same change also to main?

There might not be an immediate need for that, but I'd rather to keep things in sync.

@gsmet
Copy link
Member Author

gsmet commented Dec 1, 2023

@rsvoboda you should read what I write :).

In 3.7+, I will move these tests to their respective modules.

Given 3.7+ will be Java 17, we don't need separate modules.

@rsvoboda rsvoboda added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 1, 2023
We have seen several failures lately, let's hope this fixes it.
@gsmet
Copy link
Member Author

gsmet commented Dec 1, 2023

@rsvoboda I will also backport #37104 in this PR as it's in the way, unfortunately.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Dec 1, 2023
Copy link

quarkus-bot bot commented Dec 1, 2023

Failing Jobs - Building 042d460

Status Name Step Failures Logs Raw logs Build scan
✔️ Gradle Tests - JDK 11 🚧
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs 🚧
✔️ JVM Tests - JDK 11 🚧
✔️ JVM Tests - JDK 17 🚧
JVM Tests - JDK 17 Windows Build Failures Logs Raw logs 🚧
✔️ JVM Tests - JDK 19 🚧

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.CustomManifestArgumentsTest.shouldContainsSpecificManifestProperty line 37 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual not to be null

⚙️ JVM Tests - JDK 17 Windows #

- Failing: extensions/resteasy-reactive/rest-client-reactive/runtime 
! Skipped: extensions/keycloak-admin-client-reactive/deployment extensions/keycloak-admin-client-reactive/runtime extensions/oidc-client-reactive-filter/deployment and 30 more

📦 extensions/resteasy-reactive/rest-client-reactive/runtime

io.quarkus.rest.client.reactive.runtime.RestClientCDIDelegateBuilderTest. - More details - Source on GitHub

java.io.IOException: Failed to delete temp directory D:\a\quarkus\quarkus\extensions\resteasy-reactive\rest-client-reactive\runtime\target\junit14711420925060539310. The following paths could not be deleted (see suppressed exceptions for details): <root>, keystore.jks, truststore.jks
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.createIOExceptionWithAttachedFailures(TempDirectory.java:351)
	at org.junit.jupiter.engine.extension.TempDirectory$CloseablePath.close(TempDirectory.java:252)

@gsmet gsmet merged commit 5c44b7d into quarkusio:3.2 Dec 2, 2023
44 of 46 checks passed
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/hibernate-orm Hibernate ORM area/mongodb area/panache area/persistence OBSOLETE, DO NOT USE area/platform Issues related to definition and interaction with Quarkus Platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants