Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce LinkedIn OIDC provider #37730

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

gastaldi
Copy link
Contributor

It works!

quarkus.oidc.provider=linkedin
quarkus.oidc.client-id=<CLIENT_ID>
quarkus.oidc.credentials.client-secret.value=<CLIENT_SECRET>

@gastaldi
Copy link
Contributor Author

@sberyozkin sorry, I know the issue is assigned to you, but I was curious on seeing it in action and spent some hours trying to make it work :)

@sberyozkin
Copy link
Member

Hey @gastaldi, thanks a million for giving it a try, appreciated. Nice space optimization in the catch block too 👍

I knew this integration had to be done at some point due to the earlier commitment which is why I opened this issue but I only had some images for the docs prepared :-), I'll push some docs update a bit later on.

FYI, I believe you can optimize since they support OIDC discovery, see https://www.linkedin.com/oauth/.well-known/openid-configuration, so let me suggest some minor updates

@sberyozkin
Copy link
Member

sberyozkin commented Dec 14, 2023

@gastaldi Hi George, I suggested to remove a few configuration lines, if you'd like, please ignore them, and remove all those line as a single block. Please test the proposed config update when you will have time. Please also add a pair of tests in OidcUtilsTest (to confirm remaining properties are set as expected and that each of them can be overridden, copying 2 Google tests there would probably be easiest for this case). I can follow up then with the doc update

@gastaldi
Copy link
Contributor Author

@sberyozkin thank you! I just tested locally and your changes worked like a charm! I'll add some tests and ping you again when it's ready

Apply suggestions from code review, tests and docs

Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
Copy link

github-actions bot commented Dec 14, 2023

🙈 The PR is closed and the preview is expired.

Copy link

quarkus-bot bot commented Dec 14, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@sberyozkin
Copy link
Member

Just had to step outside, thanks @gastaldi for taking care of all of it, incl the docs, cheers

@sberyozkin sberyozkin merged commit 08bff7a into quarkusio:main Dec 14, 2023
24 checks passed
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Dec 14, 2023
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 14, 2023
@gastaldi gastaldi deleted the linkedIn_oidc branch December 14, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Support OIDC LinkedIn provider
3 participants