-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce LinkedIn OIDC provider #37730
Conversation
9a24be2
to
fd69e08
Compare
@sberyozkin sorry, I know the issue is assigned to you, but I was curious on seeing it in action and spent some hours trying to make it work :) |
Hey @gastaldi, thanks a million for giving it a try, appreciated. Nice space optimization in the catch block too 👍 I knew this integration had to be done at some point due to the earlier commitment which is why I opened this issue but I only had some images for the docs prepared :-), I'll push some docs update a bit later on. FYI, I believe you can optimize since they support OIDC discovery, see https://www.linkedin.com/oauth/.well-known/openid-configuration, so let me suggest some minor updates |
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/providers/KnownOidcProviders.java
Outdated
Show resolved
Hide resolved
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/providers/KnownOidcProviders.java
Outdated
Show resolved
Hide resolved
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/providers/KnownOidcProviders.java
Outdated
Show resolved
Hide resolved
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/providers/KnownOidcProviders.java
Outdated
Show resolved
Hide resolved
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/providers/KnownOidcProviders.java
Outdated
Show resolved
Hide resolved
extensions/oidc/runtime/src/main/java/io/quarkus/oidc/runtime/providers/KnownOidcProviders.java
Outdated
Show resolved
Hide resolved
@gastaldi Hi George, I suggested to remove a few configuration lines, if you'd like, please ignore them, and remove all those line as a single block. Please test the proposed config update when you will have time. Please also add a pair of tests in |
@sberyozkin thank you! I just tested locally and your changes worked like a charm! I'll add some tests and ping you again when it's ready |
2139c75
to
862881f
Compare
Apply suggestions from code review, tests and docs Co-authored-by: Sergey Beryozkin <sberyozkin@gmail.com>
862881f
to
0a40089
Compare
🙈 The PR is closed and the preview is expired. |
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Just had to step outside, thanks @gastaldi for taking care of all of it, incl the docs, cheers |
It works!