Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling getModifiers to remove DOMSerializer leak #37732

Closed

Conversation

galderz
Copy link
Member

@galderz galderz commented Dec 14, 2023

A workaround to avoid #37498.

Avoiding to call Constructor.getModifiers removes leaking DOMSerializer as entry point and therefore does not bring in XML baggage.

See oracle/graal#8019 for details and updates on if/how upstream will fix this.

@quarkus-bot quarkus-bot bot added the area/jackson Issues related to Jackson (JSON library) label Dec 14, 2023
@galderz galderz marked this pull request as draft December 14, 2023 08:31
@galderz
Copy link
Member Author

galderz commented Dec 14, 2023

Converting this to draft for now, pending a decision on whether this will be fixed upstream.

Copy link

quarkus-bot bot commented Dec 14, 2023

Failing Jobs - Building bc77950

Status Name Step Failures Logs Raw logs Build scan
JVM Tests - JDK 17 Build Failures Logs Raw logs 🚧
✔️ JVM Tests - JDK 21 🚧
Native Tests - Misc4 Build Failures Logs Raw logs 🚧

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment 
! Skipped: extensions/keycloak-admin-client-reactive/deployment extensions/micrometer-registry-prometheus/deployment extensions/micrometer/deployment and 36 more

📦 extensions/resteasy-reactive/rest-client-reactive/deployment

io.quarkus.rest.client.reactive.StreamJsonTest.shouldReadUpToThreeTicks line 129 - More details - Source on GitHub

java.lang.AssertionError: Expected 3 items.  Only 3 items have been received.
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItemEvents(AssertSubscriber.java:676)
	at io.smallrye.mutiny.helpers.test.AssertSubscriber.awaitItems(AssertSubscriber.java:440)

⚙️ Native Tests - Misc4 #

- Failing: integration-tests/opentelemetry-jdbc-instrumentation 

📦 integration-tests/opentelemetry-jdbc-instrumentation

Failed to execute goal io.fabric8:docker-maven-plugin:0.43.4:start (docker-start) on project quarkus-integration-test-opentelemetry-jdbc-instrumentation: I/O Error

@yrodiere
Copy link
Member

@galderz Thanks for working on this. I see oracle/graal#8041 was merged and supposedly fixes the problem; do you still want to merge this workaround or should we just wait for the fix to be included in a release of GraalVM?

@galderz galderz closed this Dec 19, 2023
@galderz galderz deleted the topic.0812.postgresql-xml-leak branch December 19, 2023 05:38
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Dec 19, 2023
@galderz
Copy link
Member Author

galderz commented Dec 19, 2023

Tested it locally and it looks fixed so closing this. No need for a workaround because this only affects unreleased GraalVM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jackson Issues related to Jackson (JSON library) triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants