Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RR client: fix chunking between \n\n in SSEParser #37866

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Dec 20, 2023

Fixes #37625

Copy link

quarkus-bot bot commented Dec 20, 2023

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should not contain an issue number (use Fix #1234 in the description instead)

This message is automatically generated by a bot.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot!

@FroMage FroMage changed the title RR client: fix chunking between \n\n in SSEParser #37625 RR client: fix chunking between \n\n in SSEParser Dec 20, 2023
Copy link

quarkus-bot bot commented Dec 20, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit 0ae38d4 into quarkusio:main Dec 20, 2023
30 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 20, 2023
@FroMage FroMage deleted the 37625 branch December 20, 2023 15:34
@gsmet gsmet modified the milestones: 3.7 - main, 3.6.5 Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSE with rest-client-reactive may lose message content when it incorrectly breaks the message delimiter (\n\n)
3 participants