Allow applications using quakus-info to contribute data to the /info using CDI

[jtama]

• Closes Provide a way for applications to contribute to the /info enpoint #37994

[jtama]

@geoand

[geoand]

Thanks, I'll have a look tomorrow

[geoand]

So if I understand correctly you want to make all implementations of InfoContributor beans automatically?

I think it would be safer to have users opt-in to that by explicitly annotating their implementations with any of the standard CDI annotations.

[geoand]

Another issue I see is that classes under runtime are considered internal, so we would probably want to move InfoContributor

[jtama]

So if I understand correctly you want to make all implementations of InfoContributor beans automatically?

I think it would be safer to have users opt-in to that by explicitly annotating their implementations with any of the standard CDI annotations.

Ok I can remove the scan then, and just let user opt-in.

Another issue I see is that classes under runtime are considered internal, so we would probably want to move InfoContributor

Ok do you want me to move it to io.quarkus.info.spi ?

Also even If i did test the extension on a local project I can't find any integration-test for this extension AND

[geoand]

Ok do you want me to move it to io.quarkus.info.spi ?

I would say move them to io.quarkus.info as it is no longer an SPI :)

Also even If i did test the extension on a local project I can't find any integration-test for this extension

We have a bunch of tests in here

[jtama]

Ok do you want me to move it to io.quarkus.info.spi ?

I would say move them to io.quarkus.info as it is no longer an SPI :)

Also even If i did test the extension on a local project I can't find any integration-test for this extension

We have a bunch of tests in here

Ok in. this case shoulld I completely remove the runtime-spi module ?

[geoand]

Actually now that I think about it, let's just leave the class in the module and package that it already resides.
The package is not great, but it's not bad enough to break extensions that already use it

[jtama]

Ok so I have something working with opt-in. But that has a drawback.

As long as now one asks specificly to get those InfoContributor instances injected, they won't be created.

Soi for this to work I had to the following to the runtime module

  @ApplicationScoped
public class ExternalContributorReporter {

    @Inject
    Instance<InfoContributor> contributors;


    public void report(Map<String, Object> finalBuildInfo) {
        contributors.forEach(contributor -> finalBuildInfo.put(contributor.name(), contributor.data()));
    }
}

And use the reporter in the InfoRecorder class.

Not sure what we prefere.

[geoand]

As long as now one asks specificly to get those InfoContributor instances injected, they won't be created.

The extension can make the beans of type InfoContributor unremovable.
That will ensure that they are always added to the application

[jtama]

I think we have something nice now

[geoand]

Looks great!

I just added a small comment worth addressing

[jtama]

Looks great!

I just added a small comment worth addressing

Stream removed

[jtama]

Fixed format.

[geoand]

Can you please squash the commits?

[github-actions]

🙈 The PR is closed and the preview is expired.