Add custom Kotlin serializers for ValidationReport and Violation #38064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Seems reasonable to me! Not sure what to make of the CI failures however... Maybe try rebasing onto |
marko-bekhta
force-pushed
the
fix/i36558-kotlin-serialization-validation-report
branch
from
a8fd23a
to
6b6cb77
Compare
|
Thanks for taking a look. Yeah, me neither ... failures do not look related, but then .. who knows 🙈 😃 |
geoand
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to register a couple of custom serializers for violation report classes if a validator dependency is available. I've added tests to a new module. As the validator is added as an optional dependency to
quarkus-resteasy-reactive-kotlin-serializationit would probably be best if we test serialization in both scenarios.