Add runtime configuration property quarkus.datasource.active
#38108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/agroal
area/docstyle
|
/cc @gsmet (hibernate-orm) |
|
🙈 The PR is closed and the preview is expired. |
yrodiere
force-pushed
the
datasource-active
branch
2 times, most recently
from
5c7d067
to
a4a58e4
Compare
yrodiere
changed the title
quarkus.datasource.active
yrodiere
force-pushed
the
datasource-active
branch
from
a4a58e4
to
01e63ec
Compare
This comment has been minimized.
This comment has been minimized.
yrodiere
force-pushed
the
datasource-active
branch
from
01e63ec
to
8586896
Compare
This comment has been minimized.
This comment has been minimized.
gsmet
reviewed
Jan 17, 2024
Comment on lines
453
to
454
| you can select a persistence unit/datasource at runtime simply by passing | ||
| xref:config-reference.adoc#multiple-profiles[setting configuration property `quarkus.profile`]: |
There was a problem hiding this comment.
simply by passing setting configuration property
quarkus.profile
sounds weird?
There was a problem hiding this comment.
Right. I rephrased to:
simply by setting
quarkus.profile
(and I did the same for the other occurrence)
yrodiere
commented
Jan 17, 2024
Comment on lines
453
to
454
| you can select a persistence unit/datasource at runtime simply by passing | ||
| xref:config-reference.adoc#multiple-profiles[setting configuration property `quarkus.profile`]: |
There was a problem hiding this comment.
Right. I rephrased to:
simply by setting
quarkus.profile
(and I did the same for the other occurrence)
yrodiere
force-pushed
the
datasource-active
branch
from
8586896
to
4f63e89
Compare
gsmet
approved these changes
Jan 17, 2024
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37265
Creating as draft, because this is based on #38106 , which should be merged first.=> DoneI tried to explain the feature in the documentation: see changes to
docs/src/main/asciidoc/datasource.adocanddocs/src/main/asciidoc/hibernate-orm.adoc. Please let me know if something is not clear.Best reviewed commit-by-commit: I split the implementation and tests. Tests are numerous, part because of the widespread impact of disabling a datasource (on flyway, metrics, health, ...), part because of the duplication of SQL client (needs one test per DB vendor).