Fix Arc request context state restoration on Vert.x duplicated context which allows to support security events in gRPC #38195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/arc
michalvavrik
force-pushed
the
feature/fix-arc-slow-ctx-activation-support-grpc-sec-event
branch
2 times, most recently
from
20085d6
to
1d8eb48
Compare
mkouba
reviewed
Jan 15, 2024
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/RequestContext.java
Outdated
Show resolved
Hide resolved
michalvavrik
force-pushed
the
feature/fix-arc-slow-ctx-activation-support-grpc-sec-event
branch
from
1d8eb48
to
81a872d
Compare
|
🙈 The PR is closed and the preview is expired. |
manovotn
reviewed
Jan 15, 2024
This comment has been minimized.
This comment has been minimized.
|
I don't think |
|
@sberyozkin please review security events portion |
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. You can consult the Develocity build scans. |
Yep, it's green after rerun 👍 |
manovotn
approved these changes
Jan 16, 2024
mkouba
approved these changes
Jan 16, 2024
michalvavrik
deleted the
feature/fix-arc-slow-ctx-activation-support-grpc-sec-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #38159
io.quarkus.arc.runtime.context.ArcContextProvider.ContextSnapshot#beginactivated new request context becauseio.quarkus.arc.InjectableContext#getStateIfActivereturned deactivated request state. This way, when firing of security events activated request context, the context arrived activate toio.quarkus.grpc.runtime.supports.context.GrpcRequestContextGrpcInterceptor#interceptCalland gRPC auth tests were failing.This PR enables security events for gRPC because it's also the only reproducer I have.