Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds RemoteCache @InjectMock support in Infinispan #39302

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

karesti
Copy link
Member

@karesti karesti commented Mar 8, 2024

  • RemoteCache is now @ApplicationScope bean
  • Includes documentation

@karesti karesti changed the title Adds RemoteCache support in Infinispan Adds RemoteCache @InjectMock support in Infinispan Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

😭 Deploy PR Preview failed.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@karesti karesti requested a review from gsmet March 11, 2024 12:49

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@quarkus-bot quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/resteasy-classic area/rest area/spring Issues relating to the Spring integration area/undertow area/vertx labels Mar 13, 2024
@karesti
Copy link
Member Author

karesti commented Mar 13, 2024

ah sorry, I'll do that

* RemoteCache is now @ApplicationScope bean
* Includes documentation
Copy link

quarkus-bot bot commented Mar 13, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit c98e2cc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

⚠️ There are other workflow runs running, you probably need to wait for their status before merging.

You can consult the Develocity build scans.

Copy link

quarkus-bot bot commented Mar 13, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit c98e2cc.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit f82cb64 into quarkusio:main Mar 13, 2024
23 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.10 - main milestone Mar 13, 2024
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 13, 2024
@karesti karesti deleted the mock-support branch March 13, 2024 15:49
@gsmet gsmet modified the milestones: 3.10 - main, 3.9.0.CR2 Mar 14, 2024
@michalvavrik
Copy link
Member

Hello, this PR contains breaking changes. It's nice that there is docs section about this breaking change, however in order to know about it, I had to find that PR or know that there is some section in the docs newly added. There is no note in migration guide in 3.9 and 3.10. Please document it for people like me who had to spend time finding it. Thank you

@karesti
Copy link
Member Author

karesti commented Mar 24, 2024

@michalvavrik my bad, the migration guide needs to be updated indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/documentation area/infinispan Infinispan area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/rest area/resteasy-classic area/spring Issues relating to the Spring integration area/undertow area/vertx kind/enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

Infinispan Extension: Allow InjectMock for RemoteCache
4 participants