Migrate Elytron Security extensions from config classes to @ConfigMapping
#39518
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following extensions fits criteria for migration of security extensions from config classes to the
@ConfigMapping
, they are not used by Quarkiverse extensions and if users are injecting these config clasess, it must be very edge case (because I can't think of reasons it's needed after inspecting their reference guides):Situation is more complex with the Elytron Security Properties File extension, it is used by Quarkiverse extensions, Kogito and Camel:
However it is used for integration and unit testing and they are not working with config classes there. For usages, I've cloned open source code and checked following projects:
Implementation note:
@ConfigMapping
s are passed to recorded methods instead of config sub-classes due to #39431PR note: feel free to squash the commits, I thought it would be better to separate commits in case we detect any issue with one of migrations